Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.4 #486

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Release 1.3.4 #486

wants to merge 6 commits into from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Oct 17, 2024

Release for the updated inflation formula from #471

This release only affects the Polkadot runtime.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it need a spec bump to the Polkadot Relay Chain runtime?

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the CHANGELOG the only diff between 1.3.3 and this proposed 1.3.4 is:

Change Polkadot inflation to 120M DOT per year (#471)

So why bump and release all (unaffected) runtimes? We could bump and release only Polkadot Relay.

@ggwpez
Copy link
Member Author

ggwpez commented Oct 21, 2024

So why bump and release all (unaffected) runtimes? We could bump and release only Polkadot Relay.

Yes true. We did partial bumps in the past, and it then becomes difficult to know what runtimes need to be bumped to what version on the next release.
Bumping all to 1.3.4 in the 1.3.4 release keeps the rule simple - just bump all to the release version.

@acatangiu
Copy link
Contributor

Releasing same runtime again but with a different spec version is not cool IMO. It adds unnecessary operational overhead to do useless runtime upgrades.

I suggest we achieve what you describe by bumping all relevant runtimes to latest spec version.

In this case, only Polkadot Relay gets 1.3.4. E.g. later say we want to release AH runtime, it would get 1.3.5 (and so will any other runtime that gets changes between now and then).

difficult to know what runtimes need to be bumped to what version on the next release

"what runtimes" -> check the changelog or git history
"what version" -> always use next "globally unique" version (1.3.4 now, next 1.3.5 or 1.4.0)

@ggwpez
Copy link
Member Author

ggwpez commented Oct 23, 2024

It adds unnecessary operational overhead to do useless runtime upgrades.

We dont upgrade them. They are just deleted from the release page. But it makes it simpler to ctrl+f update them all.

"what version" -> always use next "globally unique" version (1.3.4 now, next 1.3.5 or 1.4.0)

Yea we can also do that. Will change now to get this merged.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants