-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.3.4 #486
base: main
Are you sure you want to change the base?
Release 1.3.4 #486
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it need a spec bump to the Polkadot Relay Chain runtime?
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the CHANGELOG the only diff between 1.3.3 and this proposed 1.3.4 is:
Change Polkadot inflation to 120M DOT per year (#471)
So why bump and release all (unaffected) runtimes? We could bump and release only Polkadot Relay.
Yes true. We did partial bumps in the past, and it then becomes difficult to know what runtimes need to be bumped to what version on the next release. |
Releasing same runtime again but with a different spec version is not cool IMO. It adds unnecessary operational overhead to do useless runtime upgrades. I suggest we achieve what you describe by bumping all relevant runtimes to latest spec version. In this case, only Polkadot Relay gets 1.3.4. E.g. later say we want to release AH runtime, it would get 1.3.5 (and so will any other runtime that gets changes between now and then).
"what runtimes" -> check the changelog or git history |
We dont upgrade them. They are just deleted from the release page. But it makes it simpler to ctrl+f update them all.
Yea we can also do that. Will change now to get this merged. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Release for the updated inflation formula from #471
This release only affects the Polkadot runtime.