-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BigInt composite #5449
Open
jacogr
wants to merge
9
commits into
master
Choose a base branch
from
jg-BigInt-composite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add BigInt composite #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+99
to
+111
this.#bitLength = bitLength; | ||
this.#bitLengthInitial = this.$.toString(2).length; | ||
this.#encodedLength = this.#bitLength / 8; | ||
this.isUnsigned = !isSigned; | ||
|
||
const isNegative = this.$ < _0n; | ||
const maxBits = bitLength - (isSigned && !isNegative ? 1 : 0); | ||
|
||
if (isNegative && !isSigned) { | ||
throw new Error(`${this.toRawType()}: Negative number passed to unsigned type`); | ||
} else if (this.#bitLengthInitial > maxBits) { | ||
throw new Error(`${this.toRawType()}: Input too large. Found input with ${this.#bitLengthInitial} bits, expected ${maxBits}`); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a bit more efficient to place validation before creating instance of a class because in case invalid state no extra operations for fill instance properties.
Suggested change
this.#bitLength = bitLength; | |
this.#bitLengthInitial = this.$.toString(2).length; | |
this.#encodedLength = this.#bitLength / 8; | |
this.isUnsigned = !isSigned; | |
const isNegative = this.$ < _0n; | |
const maxBits = bitLength - (isSigned && !isNegative ? 1 : 0); | |
if (isNegative && !isSigned) { | |
throw new Error(`${this.toRawType()}: Negative number passed to unsigned type`); | |
} else if (this.#bitLengthInitial > maxBits) { | |
throw new Error(`${this.toRawType()}: Input too large. Found input with ${this.#bitLengthInitial} bits, expected ${maxBits}`); | |
} | |
if (this.$ < _0n && !isSigned) { | |
throw new Error(`${this.toRawType()}: Negative number passed to unsigned type`); | |
} | |
this.#bitLengthInitial = this.$.toString(2).length; | |
if (this.#bitLengthInitial >= maxBits) { | |
throw new Error(`${this.toRawType()}: Input too large. Found input with ${this.#bitLengthInitial} bits, greater ${maxBits}`); | |
} | |
this.#bitLength = bitLength; | |
this.#encodedLength = this.#bitLength / 8; | |
this.isUnsigned = !isSigned; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs polkadot-js/common#1716
Last piece for issues such as #5706, #3046, #490
TODO:
Int
to also use a wrapper (like here) - it is obviously a major breaking change, however does prepare the road for swap in the future