-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 41 #28
Open
bauer-git
wants to merge
10,000
commits into
pollen8:master
Choose a base branch
from
bauer-git:patch-41
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch 41 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than another one added. Still borked for WYWIYG though.
…or it in form PHP plugin. Returning false will set an element to read only.
…o get encoded into params as "nul". Need to figure out why, but for now, guard against that when getting them.
Data picker jquery time close
…ing up sometimes in JModelLegacy::getInstance() because the auto added path is FabrikadminModel, lower case a.
…uest, rather than just on list.doPlugin. Several places where if we don't, we pick up the wrong listref. Can't think of any reason not to do this on any AJAX submit.
…ent list icons, which will tae the fie extension from the element data and look for an icon for that, so for myfile.pdf would look for pdf.png (or pdf.jpg, etc)
… so en-GB becomes en_GB. New one leaves - intact.
# Conflicts: # plugins/fabrik_element/date/date-min.js
…(issues adding related data form from a usekey menu)
…to bypass "view records" ACL when creating details view for PDF attachment.
…JS to be re-minified.
…ike 'rollover'). Working on shaving some time off rendering googlemaps viz.
…_, like {fabrik_view_link}, etc., skip addSelectBoxAndLinks, which saves about 40ms per row.
…po, was a custom validation not relevant to anyone else)
… can specify custom form template to be associated with list menu item). Restriction is that you must have a form and a details template of the same name.
… (checkbox), fixing issue where it was saving map table id's rather than FK's (because it's using data from form model getData(), rather than submitted data).
…sers may try and use it)
Juser current user id in new form
…js plugin. Only difference for backward compat is 'rows' object is now keyed by row ID, rather than just being sequential from 0. Also fixed issue with code not working if list has groupby.
…empty dates. Default is false, which is backward compat.
In addition to new per-element custom labeling for 'Yes' and 'No' Adding option to use specific label text (rather than any icon or image) in list and details view. Adds logic for assuming whether entered 'file name' is an icon- Icomoon suffix for styling , or an actual image file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.