Minor Updates Across the Board - #13
Merged
Merged
Conversation
polymorcodeus
marked this pull request as draft
August 20, 2026 20:38
polymorcodeus
marked this pull request as ready for review
August 20, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
internal/web/web.go- addedErrTitleUnavailablesentinel.WebsiteTitlenow returns it for HTTP 403 and empty/missing<title>.internal/web/web_test.go- added table-driven tests covering 200/403/404/500 and empty title cases.cmd/book/mark.go:67-73-addMarkfails non-interactive adds with "provide --title", or leaves the title blank for manual entry in interactive mode.internal/web/web.go- WindowsOpenURLnow usescmd /c start <url>instead of returning a hard error.internal/catalog/toml.go-CreateTOMLnowf.Sync()s the temp file before rename, then opens/syncs/closes the parent directory after rename to make the directory entry durable.internal/catalog/toml_test.go- addedTestCollectionMapOrdering, which encodes aShelfwith collections inserted aszebra,alpha,mikeand asserts the output TOML lists them alphabetically (alpha<mike<zebra). Guards against future library regression.internal/book/types_test.go- added table-driven tests forDedupUnique,StructIsEmpty,VerifyUniqueURL,AllTags,DeleteMark,GenerateID, andMergeTags.