feat: adding git boundary for future project scope lnks - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
• internal/gitboundary — new package with ResolveGitRoot and IsInsideGitRepo , uses git rev-parse --show-toplevel
with context timeouts; handles symlinks and /var vs /private path resolution.
• service/add.go — rejects paths inside a git repo with ErrInsideGitRepo .
• service/project_add.go + cmd/root.go — added lnk project add stub; validates the path is inside a git repo, then
returns ErrProjectScopeNotImplemented .
• service/doctor.go — added cross-scope scan that flags common/host tracked paths living inside a git repo as a
cross-scope ScopeResult.
• internal/lnkerror/error.go — added ErrInsideGitRepo , ErrOutsideGitRepo , ErrProjectScopeNotImplemented .
• Tests added for gitboundary, add rejection, project add stub, and doctor cross-scope detection.
make check passes (fmt, vet, lint, unit tests, integration tests).