-
-
Notifications
You must be signed in to change notification settings - Fork 413
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make heap small chunk size setting logic more precise/correct (#4527)
Prior to this commit, the heap small chunk size setting logic would bitwise-or in the size into the appropriate bits of the small chunk but this is technically incorrect as it doesn't clear out the bits first. This commit changes the logic to ensure the relevant bits are cleared first before the new size is bitwise-or'd in.
- Loading branch information
Showing
2 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
## Fix actor heap chunk size tracking bug that could cause a segfault | ||
|
||
The [0.55.1](https://github.com/ponylang/ponyc/releases/tag/0.55.1) release included some internal actor heap implementation optimizations. Unfortunately, there was a small bug that could potentially cause a segfault due to not properly clearing some bits before setting them for some heap chunks. This change corrects that oversight to ensure the relevant bits are properly cleared before being set to ensure they final result can never be incorrect. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters