Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last vestiges of old manual CACHE_BUSTER #4156

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

SeanTAllen
Copy link
Member

It was error prone so there's a slightly less error prone way
that we moved to as represented here.

To really make this not error prone, we'd need to move the the
system as seen in:

#3825

@SeanTAllen SeanTAllen requested a review from a team July 5, 2022 22:45
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jul 5, 2022
@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Jul 5, 2022
@SeanTAllen
Copy link
Member Author

This shouldnt be merged until after #3906

Copy link
Member

@jemc jemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks good but the merge conflicts need to be resolved in a way that preserves the added fingerprinting files.

@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Jul 8, 2022
It was error prone so there's a slightly less error prone way
that we moved to as represented here.

To really make this not error prone, we'd need to move the the
system as seen in:

#3825
@SeanTAllen
Copy link
Member Author

rebased. I believe I didn't mess anything up. @jemc can you do a quick extra set of eyes to verify?

Copy link
Member

@jemc jemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good.

@SeanTAllen SeanTAllen merged commit 2c4f404 into main Jul 8, 2022
@SeanTAllen SeanTAllen deleted the more-cache-buster-gone branch July 8, 2022 20:27
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants