Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Alpine version to 3.17 and later #4407

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Aug 21, 2023

With Alpine 3.17, Alpine stopped supporting libexecinfo. In the process,
the backtrace functionality was moved into musl directly. This makes it
very hard to support both pre and post 3.17 Alpine with the compiler.

We decided to not support 3.16 and earlier as it is a decent amount of
work to support both and 3.16 is EOL in about 9 months.

As part of the change, we are updating our public docker images to be
compatiable with the change. Our public Alpine images are now based off
of Alpine 3.18.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Aug 21, 2023
@SeanTAllen
Copy link
Member Author

SeanTAllen commented Aug 22, 2023

As of alpine 3.17, there is no longer an execinfo package. We now have backtrace functionality without it.

If we follow the path of this PR, ponyc would no longer compile programs on earlier alpine's.

3.16's end of support is 2024-05-23 and it is currently receiving only bug fixes. I think given the hoops we need to jump through to support 3.16 and 3.17 and the less than a year til 3.16 is done, we should drop support for earlier alpine's and say 3.17 and later.

The current state of affairs is that without patching similar to this PR, you can't use ponyc on Alpine 3.17 and 3.18

@SeanTAllen SeanTAllen added the needs discussion Needs to be discussed further label Aug 22, 2023
@jemc
Copy link
Member

jemc commented Aug 22, 2023

Agreed on dropping support for Alpine 3.16 to avoid complexity 👍

@SeanTAllen SeanTAllen changed the title Test updating to Alpine 3.18 Drop support for Alpine versions prior to 3.16 Aug 22, 2023
@SeanTAllen SeanTAllen removed the needs discussion Needs to be discussed further label Aug 22, 2023
@SeanTAllen
Copy link
Member Author

This doesn't get a changelog as it needs two entries. I've manually included the updates.

With Alpine 3.17, Alpine stopped supporting libexecinfo. In the process,
the backtrace functionality was moved into musl directly. This makes it
very hard to support both pre and post 3.17 Alpine with the compiler.

We decided to not support 3.16 and earlier as it is a decent amount of
work to support both and 3.16 is EOL in about 9 months.

As part of the change, we are updating our public docker images to be
compatiable with the change. Our public Alpine images are now based off
of Alpine 3.18.
@SeanTAllen SeanTAllen changed the title Drop support for Alpine versions prior to 3.16 Update supported Alpine version to 3.17 and later Aug 22, 2023
@SeanTAllen SeanTAllen marked this pull request as ready for review August 22, 2023 20:46
@SeanTAllen SeanTAllen requested a review from a team August 22, 2023 20:46
@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Aug 22, 2023
@SeanTAllen
Copy link
Member Author

The timing on merging this is tricky as other images that we use for CI are based off this and might need to be updated accordingly. Once this is approved, I'll get everything else in order and do all the updates as needed.

@SeanTAllen SeanTAllen added do not merge This PR should not be merged at this time and removed do not merge This PR should not be merged at this time labels Aug 28, 2023
@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Aug 29, 2023
@SeanTAllen SeanTAllen merged commit 12a896f into main Aug 29, 2023
25 checks passed
@SeanTAllen SeanTAllen deleted the alpine-3-18 branch August 29, 2023 19:23
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants