Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PosixDate.format doc string #4450

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update PosixDate.format doc string #4450

merged 1 commit into from
Sep 19, 2023

Conversation

SeanTAllen
Copy link
Member

Note the "not at all obvious" caveat where we normalize %p and %P handling. Some locales will return an empty string for those format strings which if they are the only thing in the format string makes it impossible to know if there was success or failure from the format so we short-circuit those and make all locales return empty string if either formatting option is the only one in the format string.

Note the "not at all obvious" caveat where we normalize %p and %P
handling. Some locales will return an empty string for those format
strings which if they are the only thing in the format string makes
it impossible to know if there was success or failure from the format
so we short-circuit those and make all locales return empty string
if either formatting option is the only one in the format string.
@SeanTAllen SeanTAllen requested a review from a team September 18, 2023 14:47
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Sep 18, 2023
@SeanTAllen SeanTAllen merged commit 3bfa129 into main Sep 19, 2023
22 checks passed
@SeanTAllen SeanTAllen deleted the posix-date-format-docs branch September 19, 2023 18:08
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants