Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-assign variants #44

Open
7 tasks
daniaki opened this issue Aug 16, 2023 · 3 comments
Open
7 tasks

Re-assign variants #44

daniaki opened this issue Aug 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@daniaki
Copy link

daniaki commented Aug 16, 2023

context: https://centrepopgen.slack.com/archives/C046XUS8DGT/p1691967601787409

Option 1

Edit individual curators. This will take you to the upload page specific to a single curator.

Step 1: Click Edit for a single curator

image

Step 2: Edit via upload for a single curator (upload page not longer renders curator input field)

option-1

Option 2

Edit all curators. This will take you to the upload page which accepts a file that can contain assignments for all curators.

Step 1: Click Edit down the bottom

image

Step 2: Edit via upload for all curators (upload page as currently implemented will be re-purposed)

option-2

@SamBryen What's your preference between these two options? Also feel free to suggest new options!

Checklist

  • Add edit button to edit all curation assignments
  • Create page for editing assignments using the same CSV upload workflow
  • Indicate which assignments will be deleted and added before proceeding
  • Indicate which curation results from deleted assignments will be kept
  • Support adding multiple curators for a single variant to a CSV
  • Support download current assignments in the format that it needs to be to uploaded in
  • Add project results table column to identify results from deleted assignments
@daniaki daniaki self-assigned this Aug 16, 2023
@daniaki daniaki added the enhancement New feature or request label Aug 16, 2023
@daniaki
Copy link
Author

daniaki commented Aug 25, 2023

Additional notes:

  • Assignments will be reconfigured to match the uploaded file. Assignments no longer present will be deleted, but an existing curation result that is not *empty will be kept and marked as orphaned. These are visible and editable to project owners only.

*empty meaning no flags have been ticked, no notes have been written, and no verdict has been made.

@SamBryen
Copy link

@daniaki Option 2 is preferable as option 1 sounds more time consuming if I have multiple edits to make across multiple curators. The bulk upload in option 2 makes more sense to me.

There is currently a 'download template' option that gives you a list of all the variants currently available for assignment. Could there be a similar option to download a list of current assignments in the format that it needs to be to uploaded in? Would that be the 'download curators' option in your screenshot?

I'll also mention that you can't currently (or I failed to) assign variants to multiple curators at once. If I wanted to assign 3 people the same 10 variants, I need to create 3 different csv files and do 3 separate uploads. I'm not sure if that's because it doesn't like the repeated variant or the multiple curators listed in the same file. Thought I'd mention that incase that impacts how this new feature may work.

@daniaki
Copy link
Author

daniaki commented Aug 25, 2023

It's because the CSV validator doesn't like multiple variants in the same file regardless of who they are assigned to. I can change that! I'll also add the download option for all current assignments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants