-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab Integration #1042
Open
MusahMusah
wants to merge
34
commits into
port-labs:main
Choose a base branch
from
MusahMusah:musah/gitlab-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gitlab Integration #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Implemented Gitlab Integration
Why - The goal is to ensure that the integration is efficient, intuitive, and user-friendly, while minimizing dependencies. This enables better control over rate limits, supports real-time events, and allows for easier maintenance and testing.
How - By building an async HTTP client using Ocean's custom implementation, integrating rate-limiting mechanisms, and streamlining the setup process to make parameters more intuitive. Webhook support and real-time event handling will enhance user interaction, and verbosity and testing ensure clarity and reliability throughout development.
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
I implemented my test cases by simulating those from integrations/fake-integration. However, when I run the tests, I consistently encounter the following error:FAILED tests/test_integration.py::test_all_resync_methods - pydantic.error_wrappers.ValidationError: 1 validation error for IntegrationConfiguration unhashable type: 'list' (type=type_error)
Due to this error, I have temporarily commented out my test code here. I believe the issue may stem from the Ocean framework itself, which is why I have not removed the tests entirely. The commented-out code is retained for reference and future debugging.
Note: The test was passing in a previous version of Ocean that I had cloned locally. I suspect the error, which arises from invoking Ocean's
get_raw_result_on_integration_sync_kinds
test utility function, may have been introduced in an earlier version of the framework.Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
API Documentation
Here are the GitLab REST API endpoints that I referenced for my integrations:
WEBHOOKS
RATE LIMITS
PAGINATION