-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][PagerDuty] PORT-10680 Added default action to PagerDuty #1075
base: main
Are you sure you want to change the base?
[Integration][PagerDuty] PORT-10680 Added default action to PagerDuty #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. left some minor comment. Please apply the same to the Jira action
"method": "POST", | ||
"headers": { | ||
"RUN_ID": "{{ .run.id }}", | ||
"Authorization": "Token token={{ .secrets.PAGERDUTY_API_TOKEN }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's have a unified secret naming using secrets.variable_name. I see we have different format for the snyk and jira
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
"Authorization": "Token token={{ .secrets.pagerduty_token }}", | ||
"Accept": "application/vnd.pagerduty+json;version=2", | ||
"Content-Type": "application/json", | ||
"From": "{{ .trigger.by.user.email }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the From
part of the acceptable PagerDuty header properties? I'm curious if this is to show who the sender of the incident is from the PagerDuty dashboard
Description
What -
Implemented a default "Trigger incident" action for the PagerDuty Integration. This action allows users to create a PagerDuty incident with user inputs for title and description, notifying the on-call team of critical issues.
Why -
To improve the ease of creating and managing incidents within the PagerDuty integration. This default action helps users quickly trigger incidents with minimal configuration, driving higher engagement and adoption. It also leverages the new secret referencing feature for secure interactions via webhooks.
How -
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.