Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terraform security groups #48

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Conversation

yairsimantov20
Copy link
Collaborator

Description

What - The ecs didnt use the correct security group
Why - The elb outputed incorrect values
How - outputing the correct values

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

@MatanHeledPort MatanHeledPort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yairsimantov20 yairsimantov20 merged commit 5fa49bc into main Aug 3, 2023
1 check passed
@yairsimantov20 yairsimantov20 deleted the fix-terraform-security-groups branch August 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants