Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-4088-Add-spec.yaml-to-each-integration-and-load-it-to-the-UI #7

Conversation

yairsimantov20
Copy link
Collaborator

@yairsimantov20 yairsimantov20 commented Jul 12, 2023

Description

What - Spec yaml should hold the metadata about the integration & the integration should validate its config according to the spec yaml configurations field

Why - In order to display the integration in the ui and it will need to hold this metadata

How - Created spec yaml in the cookie cutter & Generating dynamic pydantic model according to the spec yaml to validate the configurations

Type of change

Please leave one option from the following and delete the rest:

  • New feature (non-breaking change which adds functionality)

@yairsimantov20 yairsimantov20 changed the title coockie cutter spec file && validating the configuration by the specf… PORT-4088-Add-spec.yaml-to-each-integration-and-load-it-to-the-UI Jul 12, 2023
Copy link
Collaborator

@danielsinai danielsinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦢

…-Add-spec.yaml-to-each-integration-and-load-it-to-the-UI

# Conflicts:
#	port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/config.yaml
@yairsimantov20 yairsimantov20 merged commit 89d2512 into main Jul 13, 2023
1 check passed
@yairsimantov20 yairsimantov20 deleted the PORT-4088-Add-spec.yaml-to-each-integration-and-load-it-to-the-UI branch July 23, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants