Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 4250 add default blueprint and mapping for integration #8

Merged

Conversation

yairsimantov20
Copy link
Collaborator

@yairsimantov20 yairsimantov20 commented Jul 13, 2023

Description

What - Created a way for the integration developer to specify blueprints, scorecards, actions, port_app_config to be created once the (and only when) the integration is installed
Why - We want the experience with Ocean to feel as plug-and-play as possible
How - Created a default folder inside .port folder that holds default data for those objects

Type of change

  • New feature (non-breaking change which adds functionality)

Copy link
Collaborator

@danielsinai danielsinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

port_ocean/port_defaults.py Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
Copy link
Member

@MPTG94 MPTG94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments around things I found, if there is something specific you wanted me to take a look at that I missed please let me know

port_ocean/context/ocean.py Show resolved Hide resolved
port_ocean/port_defaults.py Show resolved Hide resolved
port_ocean/port_defaults.py Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
port_ocean/port_defaults.py Outdated Show resolved Hide resolved
@yairsimantov20 yairsimantov20 merged commit 2e8661d into main Jul 18, 2023
1 check passed
@yairsimantov20 yairsimantov20 deleted the PORT-4250-Add-default-blueprint-and-mapping-for-integration branch July 18, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants