-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 4250 add default blueprint and mapping for integration #8
Merged
yairsimantov20
merged 27 commits into
main
from
PORT-4250-Add-default-blueprint-and-mapping-for-integration
Jul 18, 2023
Merged
Port 4250 add default blueprint and mapping for integration #8
yairsimantov20
merged 27 commits into
main
from
PORT-4250-Add-default-blueprint-and-mapping-for-integration
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsinai
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
pazhersh
approved these changes
Jul 16, 2023
MPTG94
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments around things I found, if there is something specific you wanted me to take a look at that I missed please let me know
…-Add-default-blueprint-and-mapping-for-integration
yairsimantov20
deleted the
PORT-4250-Add-default-blueprint-and-mapping-for-integration
branch
July 18, 2023 07:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Created a way for the integration developer to specify blueprints, scorecards, actions, port_app_config to be created once the (and only when) the integration is installed
Why - We want the experience with Ocean to feel as plug-and-play as possible
How - Created a default folder inside
.port
folder that holds default data for those objectsType of change