--deterministic option added #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns off all multi-threading and any use of randomized seeds so that the same exact output files will be produced from the same input file and settings.
This is a useful feature for unit testing (where you can compare the output file with what it is supposed to be), and for applications where the output files are hosted on a content addressed file system (ie addressed by, say, its sha256sum) such as IPFS.
While it's technically possible to have determinism in multithreading (I would start with an implementation of the indexer phase where the
onNodeCompletedsleeps and holds back the results from being written till the previous jobs in the queue have been committed first to maintain ordering) it's quite complicated. It should therefore only be implemented when the deterministic mode proves useful enough to justify it.