[PLAY-1586] Timeline Sub Sub Components #3801
Conversation
markdoeswork
added
the
milano
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1586datearea |
markdoeswork
added
enhancement
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.5.0.pre.alpha.play1586datearea4115 Your Alpha for NPM is 14.5.0-alpha.play1586datearea4115 |
| <%= pb_rails("timeline", props: {orientation: "horizontal", show_date: true}) do %> | ||
| <%= pb_rails("timeline/item", props: { line_style: "solid"}) do |item| %> | ||
|
|
||
| <% item.date_area do %> |
There was a problem hiding this comment.
specifying the item.date_area allows us to only update the date area
you don't have to provide the node or detail area if you don't want to.
This is needed because our node area has default functionally and it will use the icon circle kit it you dont't put anything
There was a problem hiding this comment.
After doing more research i found that github's design system uses the same pattern https://primer.style/components/action-menu/rails/alpha#examples
|
@markdoeswork Hey Mark! I went ahead and threw my feedback into a gist: the gist |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.6.0.pre.alpha.play1586datearea4218 Your Alpha for NPM is 14.6.0-alpha.play1586datearea4218 |
|
@jasperfurniss i made the updates you suggested and have a working code sandbox https://codesandbox.io/p/sandbox/timeline-alpha-forked-9j4dxg |
What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1586
In this story we let devs add children or "what ever kit they want" to the date and node area of the timeline kit
The major changes to react is in the
playbook/app/pb_kits/playbook/pb_timeline/_item.tsxand in rails i added a new pattern to be able to conditionally render fragments of contentI have an alpha here https://github.com/powerhome/nitro-web/pull/43266
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.