Allow for new database.yml configurations with roles #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadewinningham
commented
Jun 3, 2024
|
Successful dev dump test. |
|
@wadewinningham edgestitch also reaches for database configuration directly. It does it differently, though: https://github.com/powerhome/power-tools/blob/main/packages/edgestitch/lib/edgestitch/tasks.rb#L73C1-L74C1 |
xjunior
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Rails applications may be using a configuration for multiple databases.
By default, Rails will look for
primarynamed connection details and use those with multiple db setup. The changes in this PR will look for and use theprimarysettings if the key exists, otherwise, it will assume it's normal, single db, database setttings which would be compatible with previous versions of Rails.