Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The intent of the Challenge-response is too coupled with the app #21

Open
J-Jamet opened this issue May 30, 2022 · 1 comment
Open

The intent of the Challenge-response is too coupled with the app #21

J-Jamet opened this issue May 30, 2022 · 1 comment

Comments

@J-Jamet
Copy link

J-Jamet commented May 30, 2022

Your work is a source of aspiration, so I already thank you for the creation of this project.

I had planned to connect KeePassDX directly to ykDroid but there is a little something that bothers me.
The intent "net.pp3345.ykdroid.intent.action.CHALLENGE_RESPONSE" contains your package name and it would be better to create a more generic intent to harmonize and let the user choose natively if another application is created (and to not replace it if the user does not want to).

I was thinking about "android.yubikey.intent.action.CHALLENGE_RESPONSE", tell me if it's generic enough and if you want to integrate it in ykDroid too.

@uduerholz
Copy link

Maybe you don't replace the intent name but add it as a second intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants