Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android.yubikey.intent.action.CHALLENGE_RESPONSE intent #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

J-Jamet
Copy link

@J-Jamet J-Jamet commented Aug 5, 2022

PR linked to #21

  • Add android.yubikey.intent.action.CHALLENGE_RESPONSE intent
  • Add KeePassDX in README

@pp3345
Copy link
Owner

pp3345 commented Aug 29, 2022

I am sorry for the late reply. I am fine with adding KeePassDX to the README, however, I am concerned about the proposed new name for the intent for two reasons:

  • I believe that the "android" namespace is reserved for Android itself and user applications shouldn't add their own intents there. Please correct me if I am wrong.
  • "YubiKey" is a copyrighted trademark. ykDroid was initially called "YubiDroid", but then Yubico came and threatened to sue me over the name, hence I renamed it to ykDroid. I am not sure whether they would be fine with this. I might be overreacting here.

@J-Jamet
Copy link
Author

J-Jamet commented Aug 30, 2022

I believe that the "android" namespace is reserved for Android itself and user applications shouldn't add their own intents there. Please correct me if I am wrong.

What do you mean by reserving it for Android itself?
It's not annoying in my opinion especially for an Intent that is meant to be shared and harmonized to make it a standard. It would be more annoying if third party applications use Android namespace as package name, even if some of them do it and are approved by the PlayStore (com.android.KeePass -> KeePassDroid). But we can remove the word android if it bothers you.

"YubiKey" is a copyrighted trademark. ykDroid was initially called "YubiDroid", but then Yubico came and threatened to sue me over the name, hence I renamed it to ykDroid. I am not sure whether they would be fine with this. I might be overreacting here.

Agree with this, even if it goes against their marketing plan to spread the name. In this case we can use the "ykdroid" name generically, that would fit the protocol you initially set up. without your package name.

I am making another driver application that will be compatible with Yubikey and SoloKey (Fido2) on the same principle as your protocol. If you don't mind, I'll reuse the name "ykDroid" to indicate that the intent format is compatible with yours. If it bothers you, I can use "ykey" name.

What do you think of :
ykdroid.intent.action.CHALLENGE_RESPONSE

or

ykey.intent.action.CHALLENGE_RESPONSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants