Fully remove the MemberChangeAction when you unbind. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that causes objects to never get disposed to do a neverending strong reference
|
Fixes #12 |
Sevenish
reviewed
Jan 27, 2022
There was a problem hiding this comment.
This will break things when multiple member actions are bound to the same property.
Add a check for other actions:
if (!subs.HasActions) objectSubs.Remove(key);
This needs something HasActions in class MemberActions
public bool HasActions => actions.Count != 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that causes objects to never get disposed to do a neverending strong reference