-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a GoogleMap control to the Ooui project and added a Ooui.Forms.Maps project to support it #160
base: master
Are you sure you want to change the base?
Conversation
- Modified Client.js (ooui.js) to support raising and listening to custom events
…entre functionality. - Added Map Sample
…i.GoogleMap control
Oh, good another nuget haha ;-) This is great work, thank you. I want to review it before merging. I'm not sold on the separate nuget... what is the actual benefit? |
It does not need to be a separate nuget, but to keep consistent with how Xamarin manages their components it would make sense to follow the same approach. Especially since combining the projects would mean that any user of Ooui forms will have a possible unnecessary dependency on Xamarin.Forms.Maps even though they may not need to use maps, this would lighten the requirements for the base Ooui.Forms (but also increase it to an additional package for users who do want to use maps). |
I was just reviewing the code and saw that your tore up the event system. Can you explain why? What feature wasn't available that required all these changes? |
I needed to be able to pass and receive full JSON objects that map to classes on the GoogleMaps control, and the event system only allowed for
|
It would be cool if this request was accepted 😎 |
Ooui Project
Ooui.Forms.Maps Project (NEW)
The Ooui.Forms.Maps is a separate project from Ooui.Forms, because Xamarin.Forms.Maps is separate from Xamarin.Forms, and it would be unnecessary for Ooui.Forms to have a dependency on the maps project if it is not part of the default package. If this is used as a separate project, it would probably need to become its own nuget package as well.
Samples Project
The resulting control looks like the below (depending on Map Type option, etc):