AMX Bid Adapter : remove hardcoded, depricated fields, cast sync settings, add configuration data #12234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct type, add configuration metadata
ChrisHuie
changed the title
patmmccann
reviewed
Sep 24, 2024
| @@ -17,7 +17,7 @@ This module connects web publishers to AMX RTB video and display demand. | |||
| | Key | Required | Example | Description | | |||
| | --- | -------- | ------- | ----------- | | |||
| | `testMode` | no | `true` | this will activate test mode / 100% fill with sample ads | | |||
| | `tagId` | no | `"cHJlYmlkLm9yZw"` | can be used for more specific targeting of inventory. Your account manager will provide this ID if needed | | |||
| | `tagId` | yes | `"cHJlYmlkLm9yZw"` | can be used for more specific targeting of inventory. Your account manager will provide this ID if needed | | |||
There was a problem hiding this comment.
making this required appears to be breaking?
patmmccann
reviewed
Sep 24, 2024
| @@ -111,6 +93,24 @@ function createBidMap(bids) { | |||
| return out; | |||
| } | |||
|
|
|||
| function ensureNumber(value, defaultValue) { | |||
There was a problem hiding this comment.
would this be generaly useful? perhaps import it from somewhere others can access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This update removes some deprecated and hardcoded fields, casts sync settings to correct (numeric) types to correct for unexpected input, and attaches some configuration settings to the request to provide additional context about the page.
Updated documentation:
tagIdparameter is required. The documentation file here now matches the docs (which already hadtagIdas required)