Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename eslint-plugin-prebid to eslint-plugin-prebidjs #12260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renebaudisch
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

rename eslint-plugin-prebid to eslint-plugin-prebidjs to separate this local module from the vulnerable npm clone

Other information

Fixes (and should eventually close):

@patmmccann
Copy link
Collaborator

Doesn't this just invite someone to publish malware to the new location?

@renebaudisch
Copy link
Contributor Author

Good point... but, what could be done then?
How about publishing the module within the new namespace to npm to avoid someone hijacking the namespace?

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 23, 2024

that could work, i'll keep this unmerged while we explore with npm

can you merge in master? I merged the dependency pr you did.

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 24, 2024

How about publishing the module within the new namespace to npm to avoid someone hijacking the namespace?

open to this and/or upgrading the linter. What's the next step?

@renebaudisch
Copy link
Contributor Author

How about publishing the module within the new namespace to npm to avoid someone hijacking the namespace?

open to this and/or upgrading the linter. What's the next step?

Someone needs to publish this lint-module to npm:
publishing-unscoped-public-packages or
publishing-scoped-public-packages

But as I'm not the author of this plugin, I'm not comfortable doing this by myself...

…is local module from the vulnerable npm clone)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants