Core: support for expandable / flex slots #12379
Open
+175
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulieLorin
reviewed
Nov 2, 2024
| logWarn(`Ad unit banner.format specifies both w/h and wratio/hratio`, adUnit); | ||
| return false; | ||
| } | ||
| return (w ?? h ?? wratio ?? hratio) != null; |
There was a problem hiding this comment.
shouldn't we check that w AND h aren't null or wratio AND hratio aren't null ? Instead of having just one non null value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This adds better support for banner slots with flexible sizes:
formatarray instead ofsizesfor an ad unit'smediaTypes.banner;expdircan also be supplied there for convenience (alias ofortb2Imp.banner.expdir);wratio/hratioinstead of width and height;{wratio: 2, hratio: 1}becomes[2, 1]);Other information
#9361