New Adapter: Nativo #3790

rafataveira · 2024-07-03T06:28:54Z

No description provided.

github-actions · 2024-07-03T06:44:52Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8c798c9

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:48:	MakeBids		92.9%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:89:	getMediaTypeForImp	100.0%
total:									(statements)		93.8%

rafataveira · 2024-07-18T16:25:16Z

@onkarvhanumante Is there any ETA for reviewing this PR?
When is the next version expected to be released?
TIA

onkarvhanumante · 2024-08-01T17:03:32Z

@rafataveira PR tests are failing due to file miss format. Requesting to format files

Run ./validate.sh --nofmt --cov --race 10
gofmt needs to be run, 2 files have issues.  Below is a list of files to review:
adapters/nativo/nativo.go
adapters/nativo/nativo_test.go

ashishshinde-pubm · 2024-08-08T03:32:38Z

@rafataveira Does this bidder supports request.test parameter and respond with dummy response ? or is there any way this bidder can return dummy response for test purpose ?

przemkaczmarek · 2024-08-09T12:49:54Z

static/bidder-info/nativo.yaml

@@ -0,0 +1,19 @@
+endpoint: "https://exchange.postrelease.com/esi?ntv_epid=7"
+maintainer:
+  email: "prebiddev@nativo.com"


I've sent an email to this address to confirm it is correct. Please respond to the email with a "received" message.

It is correct. I've just replied to the email.

mail confirmed

przemkaczmarek · 2024-08-09T13:28:41Z

static/bidder-params/nativo.json

+    "title": "Nativo Adapter Params",
+    "description": "A schema which validates params accepted by the Nativo adapter",
+    "type": "object",
+


NIP, please delete white line

przemkaczmarek · 2024-08-09T13:37:09Z

adapters/nativo/nativo_test.go

+
+func TestBidderNativo(t *testing.T) {
+	bidder, buildErr := Builder(openrtb_ext.BidderNativo, config.Adapter{
+			Endpoint: "https://foo.io/?src=prebid"},


why is it "https://foo.io/?src=prebid" ?
It should be endpoint from yaml

przemkaczmarek · 2024-08-09T13:38:58Z

static/bidder-info/nativo.yaml

@@ -0,0 +1,19 @@
+endpoint: "https://exchange.postrelease.com/esi?ntv_epid=7"


"esi?ntv_epid=7" does not look fine

this is correct, that's the url to our exchange server, in this case, prebid server.

adapters/nativo/nativo.go

static/bidder-info/nativo.yaml

adapters/nativo/nativo.go

static/bidder-info/nativo.yaml

rafataveira · 2024-08-15T20:23:56Z

@onkarvhanumante I will review all comments and make the changes accordingly.

github-actions · 2024-08-15T22:02:46Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 46e7869

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:48:	MakeBids		92.9%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:89:	getMediaTypeForImp	100.0%
total:									(statements)		93.8%

github-actions · 2024-08-27T18:37:23Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3e8a7db

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:48:	MakeBids		92.9%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:89:	getMediaTypeForImp	100.0%
total:									(statements)		93.8%

przemkaczmarek · 2024-09-25T12:40:24Z

works:

bsardo · 2024-09-25T15:11:05Z

works:

I see this 200 response as well but it is supposed to redirect (302) to the PBS setuid endpoint which is specified in your ntv_r parameter. @rafataveira

rafataveira · 2024-09-26T16:12:01Z

@bsardo This is the result of the redirect I get:
https://prebid.adnxs.com/pbs/v1/setuid?bidder=Nativo&gdpr=&gdpr_consent=&f=i&uid=%22c0ed3c17-4ba0-4d2e-9cf2-cbf8f9037793%22

bsardo · 2024-09-30T14:53:17Z

@bsardo This is the result of the redirect I get: https://prebid.adnxs.com/pbs/v1/setuid?bidder=Nativo&gdpr=&gdpr_consent=&f=i&uid=%22c0ed3c17-4ba0-4d2e-9cf2-cbf8f9037793%22

Hi @rafataveira, I suggest testing your user sync with localhost so that your bidder is known and so that you can ensure your server redirects to the setuid endpoint of the PBS host, which in this case will be the localhost setuid endpoint. Start this process by first hitting the localhost PBS cookie sync endpoint:
POST localhost:8000/cookie_sync with body {"bidders": ["nativo"]} and that will give you the url that would be dropped as a pixel kicking off the cookie sync that should ultimately redirect to the setuid endpoint.

github-actions · 2024-10-01T15:01:42Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, fec9463

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:26:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:46:	MakeBids		83.3%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:83:	getMediaTypeForImp	88.9%
total:									(statements)		86.1%

rafataveira · 2024-10-01T15:02:34Z

@bsardo This is the result of the redirect I get: https://prebid.adnxs.com/pbs/v1/setuid?bidder=Nativo&gdpr=&gdpr_consent=&f=i&uid=%22c0ed3c17-4ba0-4d2e-9cf2-cbf8f9037793%22

Hi @rafataveira, I suggest testing your user sync with localhost so that your bidder is known and so that you can ensure your server redirects to the setuid endpoint of the PBS host, which in this case will be the localhost setuid endpoint. Start this process by first hitting the localhost PBS cookie sync endpoint: POST localhost:8000/cookie_sync with body {"bidders": ["nativo"]} and that will give you the url that would be dropped as a pixel kicking off the cookie sync that should ultimately redirect to the setuid endpoint.

I found the issue with the double quotes on userMacro. Now it should work as expected.

bsardo · 2024-10-03T14:44:57Z

@rafataveira we're still seeing an issue with the user sync. Your server is responding with a 200. Since you've classified this user sync as type redirect, your server should be responding with a 302 redirect to the url defined in the ntv_r parameter with the user id macro populated.

rafataveira · 2024-10-07T19:34:03Z

@bsardo I couldn't reproduce this behaviour. As you can see, our server responds with 302 and correctly redirects to the URL defined in the ntv_r parameter with the user ID macro populated.

This is the same cookie sync URL used by Prebid Server Java version and other partners.
Also, make sure to use the secure URL (https).

https://jadserve.postrelease.com/suid/101787?gdpr=&gdpr_consent=&us_privacy=&ntv_gpp_consent=&ntv_r=https%3A%2F%2Fprebid.adnxs.com%2Fpbs%2Fv1%2Fsetuid%3Fbidder%3DNativo%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3DNTV_USER_ID

rafataveira · 2024-10-17T15:26:33Z

@onkarvhanumante @przemkaczmarek @bsardo, is the cookie sync URL the only thing preventing you from approving this PR? We have some clients waiting for the GO version to go live for quite some time. Could you please go ahead and approve it? The cookie sync URL is the same as prebid-server-java and other partners, and it is working as expected.

bsardo · 2024-10-17T18:02:09Z

@onkarvhanumante @przemkaczmarek @bsardo, is the cookie sync URL the only thing preventing you from approving this PR? We have some clients waiting for the GO version to go live for quite some time. Could you please go ahead and approve it? The cookie sync URL is the same as prebid-server-java and other partners, and it is working as expected.

Hi @rafataveira, yes the user sync is the only thing holding this up. We tried the URL you provided as well and it is still not working for me or Peter and we are based in the US and Poland respectively in case this is a geographic region issue. We are still seeing a 200 instead of a 302 redirect. This issue needs to be resolved before merging this PR as is unless you want to break the user sync functionality out into a separate PR so that the rest of this can be merged now. At this point, I am leaving the user sync investigation up to you though I will triple check with another team member that the 200 issue is occurring and report back later today.

rafataveira · 2024-10-18T18:45:14Z

@bsardo I see what is happening to your validation. This is a production cookie sync URL which has different kinds of internal validations to avoid fraud and won't redirect if a possible fraud is detected. It works for me because I am in a VPN environment. This has nothing to do with our GO version adapter at all. If this is still a blocker for you to approve this PR, (even though it is not a problem) we can remove it from this PR and also, change our validation for Prebid Server to always redirect. Let me know what you recommend.

bsardo · 2024-10-22T15:32:49Z

@rafataveira we're required to verify the user sync endpoints works. Can you either provide details on how to construct a request so that it is not flagged by your servers as potential fraud or change your server validations so that the URL generated by the cookie sync endpoint always results in a redirect? I'll leave that decision to you at this time as I'm not aware of how your validation works.

rafataveira · 2024-10-25T23:06:46Z

@bsardo we have pushed a fix for the redirect validation. Can you please validate and if all looks good can we merge the PR?

aparekh-nativo · 2024-10-29T16:26:29Z

@bsardo can we get an update on the cookie sync validation ?

github-actions · 2024-11-01T15:50:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6d45678

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:26:	MakeRequests		85.7%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:46:	MakeBids		83.3%
github.com/prebid/prebid-server/v2/adapters/nativo/nativo.go:83:	getMediaTypeForImp	88.9%
total:									(statements)		86.1%

bsardo · 2024-11-01T16:34:25Z

Hi @aparekh-nativo, @rafataveira tests are failing and your PR branch does not run because you have some incorrect package references after merging with master. All package imports should reference v3 instead of v2. It looks like the offending files are adapter_builders.go, nativo.go and nativo_test.go. Yesterday we released PBS 3.0 which updated all package references to v3. See #4029.

github-actions · 2024-11-04T16:06:53Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 96b26e9

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:26:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:46:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:83:	getMediaTypeForImp	88.9%
total:									(statements)		86.1%

github-actions · 2024-11-04T16:16:40Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e35a49e

nativo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:26:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:46:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/nativo/nativo.go:83:	getMediaTypeForImp	88.9%
total:									(statements)		86.1%

rafataveira · 2024-11-04T20:40:47Z

@bsardo The merge issue and test failures are fixed. Could you please go ahead and merge it?

bsardo · 2024-11-04T22:14:11Z

Hi @rafataveira, now I see the redirect working but the user id macro NTV_USER_ID is not being populated:

Your server appears to just be echoing whatever I send as uid=.

rafataveira added 4 commits July 3, 2024 01:23

New Adapter: Nativo

0f1af65

Merge branch 'master' of https://github.com/NativoPlatform/prebid-server

7f56ab1

Nativo: fix tests

59e57cb

Nativo: fix tests

8c798c9

gargcreation1992 assigned onkarvhanumante and Sonali-More-Xandr Jul 25, 2024

bsardo assigned przemkaczmarek and unassigned Sonali-More-Xandr Aug 1, 2024

przemkaczmarek reviewed Aug 9, 2024

View reviewed changes