New Adapter: Insticator #3806

shubhamc-ins · 2024-07-10T18:31:01Z

* init insticator adaptor * update modules * add mediaType for bids * update insticator adaptor with tests * update insticator for test cases * fix test cases * update InstAdapter * update insticator adaptor * fix test cases for adUnitId * update insticator adapter type * Updates - add currency converter support - Add video validation support * remove default plcmt and placement * add more test cases * update for publisher ID * fix tests

* add multi-imps testJson * fix pubId parsing for request

github-actions · 2024-07-10T18:31:47Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 92e859a

insticator

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:99:	Error				0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:104:	isInteger			0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:118:	isArrayOfNums			0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:170:	toInt				0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:185:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:193:	getMediaTypeForBid		100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:204:	getBidType			0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:212:	MakeRequests			80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:268:	makeRequest			50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:304:	MakeBids			80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:344:	makeImps			85.7%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:393:	validateVideoParams		85.7%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:413:	makeReqExt			80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:435:	resolveBidFloor			50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:445:	roundTo4Decimals		0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:449:	validateOptionalVideoParams	68.8%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:484:	toCamelCase			0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:492:	isZeroOrNil			0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:506:	populatePublisherId		27.3%
total:										(statements)			57.6%

onkarvhanumante · 2024-08-06T09:17:18Z

adapters/insticator/insticator.go

+// type adapter struct {
+// 	endpoint string
+// }
+


should remove this comment

onkarvhanumante · 2024-08-06T09:25:59Z

adapters/insticator/insticator.go

+// CALLER Info used to track Prebid Server
+// as one of the hops in the request to exchange
+var CALLER = InsticatorCaller{"Prebid-Server", "n/a"}


Accessibility scope of CALLER is public i.e can be accessed outside of insticator package. Should make it private as done below:

// caller Info used to track Prebid Server // as one of the hops in the request to exchange var caller = InsticatorCaller{"Prebid-Server", "n/a"}

onkarvhanumante · 2024-08-06T09:30:07Z

static/bidder-info/insticator.yaml

@@ -0,0 +1,17 @@
+endpoint: "https://ex.ingage.tech/v1/prebidserver"


endpoint is reachable.

% curl -i --location --request POST 'https://ex.ingage.tech/v1/prebidserver' HTTP/2 403 date: Tue, 06 Aug 2024 09:27:09

@shubhamc-ins are there any geo location restriction for insticator adapter? Because received following error as curl response

<!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Access Restricted</title> <style> body { font-family: Arial, sans-serif; text-align: center; padding: 50px; } h1 { color: #ff0000; } </style> </head> <body> <h1>Access Restricted</h1> <p>We're sorry, but access to this service is restricted from your location. Error code: 1</p> <p>If you believe this is an error, please contact our support team.</p> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'8aedfd4b2a2e3c5e',t:'MTcyMjkzNjQyOS4wMDAwMDA='};var a=document.createElement('script');a.nonce='';a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script></body> </html>

@onkarvhanumante yes, we do have geo restrictions on ingage.tech domain. You should be to access it via VPN using America/Canada region.

onkarvhanumante · 2024-08-06T09:33:59Z

static/bidder-info/insticator.yaml

+endpoint: "https://ex.ingage.tech/v1/prebidserver"
+maintainer:
+  email: "predid@insticator.com"
+gvlVendorID: 910


verified gvl id

% curl https://vendor-list.consensu.org/v2/vendor-list.json | jq '.vendors."910"' % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 430k 100 430k 0 0 2811k 0 --:--:-- --:--:-- --:--:-- 2830k { "id": 910, "name": "Insticator, Inc.", "purposes": [ 1, 2, 3, 4, 5, 6, 7, 8, 10 ], "legIntPurposes": [], "flexiblePurposes": [ 2, 5, 6, 7, 8, 10 ], "specialPurposes": [ 1, 2 ], "features": [ 3 ], "specialFeatures": [], "policyUrl": "https://www.insticator.com/privacy/", "cookieMaxAgeSeconds": 25920000, "usesCookies": true, "cookieRefresh": false, "usesNonCookieAccess": true, "deviceStorageDisclosureUrl": "https://insticator.com/device-storage-disclosure.json" }

onkarvhanumante · 2024-08-06T09:36:57Z

static/bidder-info/insticator.yaml

@@ -0,0 +1,17 @@
+endpoint: "https://ex.ingage.tech/v1/prebidserver"
+maintainer:
+  email: "predid@insticator.com"


Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread

onkarvhanumante · 2024-08-06T09:39:40Z

adapters/insticator/insticator.go

+}
+
+// Placeholder for the actual openrtb2.Video struct
+type Video struct {


Video struct is unused. Should remove it.

onkarvhanumante · 2024-08-06T09:40:37Z

adapters/insticator/insticator.go

+// 	endpoint string
+// }
+
+type Ext struct {


should be private

type ext struct { Insticator impInsticatorExt `json:"insticator"` }

onkarvhanumante · 2024-08-06T09:41:44Z

adapters/insticator/insticator.go

+	Insticator impInsticatorExt `json:"insticator"`
+}
+
+type insticatorUserExt struct {


insticatorUserExt struct is unused. Should remove it.

onkarvhanumante · 2024-08-06T09:43:17Z

adapters/insticator/insticator.go

+type InsticatorCaller struct {
+	Name    string `json:"name,omitempty"`
+	Version string `json:"version,omitempty"`
+}
+


should be private

type insticatorCaller struct { Name string `json:"name,omitempty"` Version string `json:"version,omitempty"` }

onkarvhanumante · 2024-08-06T09:44:40Z

adapters/insticator/insticator.go

+type BadInput struct {
+	Message string
+}
+
+func (e *BadInput) Error() string {
+	return e.Message
+}
+


BadInput is unused. Should remove it.

onkarvhanumante · 2024-08-06T09:46:11Z

adapters/insticator/insticator.go

+func getBidType(ext bidExt) openrtb_ext.BidType {
+	if ext.Insticator.MediaType == "video" {
+		return openrtb_ext.BidTypeVideo
+	}
+
+	return openrtb_ext.BidTypeBanner
+}


function getBidType is unused. Should remove this function.

onkarvhanumante · 2024-08-06T10:40:07Z

adapters/insticator/insticator.go

+	if imp.Banner == nil && imp.Video == nil {
+		return openrtb2.Imp{}, &errortypes.BadInput{
+			Message: fmt.Sprintf("Imp ID %s must have at least one of [Banner, Video] defined", imp.ID),
+		}
+	}


static/bidder-info/insticator.yaml mentions Banner and Video as required media types params. Therefore, Prebid core framework will ensure incoming request has Banner and Video details for insticator bidder.

Therefore, can exclude this check from adapter

onkarvhanumante · 2024-08-06T10:56:46Z

adapters/insticator/insticator.go

+		videoCopy, err := validateVideoParams(imp.Video)
+
+		imp.Video = videoCopy
+
+		if err != nil {
+			return openrtb2.Imp{}, &errortypes.BadInput{
+				Message: err.Error(),
+			}
+		}


should remove line space on line 381 and line 384

error check should be done before assigning value to imp.Video

create copy of imp in makeImps and then make changes in imp copy

videoCopy, err := validateVideoParams(imp.Video) if err != nil { return openrtb2.Imp{}, &errortypes.BadInput{ Message: err.Error(), } } imp.Video = videoCopy

onkarvhanumante · 2024-08-06T11:20:59Z

adapters/insticator/insticator.go

+	v := reflect.ValueOf(video).Elem()
+	t := v.Type()
+
+	for i := 0; i < t.NumField(); i++ {
+		field := t.Field(i)
+		fieldValue := v.Field(i)
+
+		// Convert the field name to camelCase for matching in optionalVideoParams map


Usage of reflection should be avoided.

Also looks like validateOptionalVideoParams is validating if correct values are parsed and assigned to the fields of *openrtb2.Video struct. This step is not needed.

Because adapter code will receive parsed values. Here MakeRequests receives request *openrtb2.BidRequest. and request.Imp[$].Video is already validated during parsing.

func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo)

Parsing done before MakeRequests call ensures that incoming values are valid and parsable into struct.

For example, request.Imp[$].Video.MinDuration has int64 type. Here parsing will fail if incoming request has value that cannot be parsed as int64

@shubhamc-ins you could simply use values and make sure it is suitable for your business logic.

prebid-server/adapters/insticator/insticator.go

Line 142 in b751ff9

var validLinearity = map[int]bool{1: true}

prebid-server/adapters/insticator/insticator.go

Lines 144 to 149 in b751ff9

var validPlaybackEnd = map[int]bool{1: true, 2: true, 3: true}

var validPos = map[int]bool{0: true, 1: true, 2: true, 3: true, 4: true, 5: true, 6: true, 7: true}

// Map parameters to validation functions

var optionalVideoParams = map[string]func(interface{}) bool{

"minduration": isInteger,

For example, your adapter requires linearity to be 1. Here code can be restructured as below:

func validateOptionalVideoParams(video *openrtb2.Video) (*openrtb2.Video, error) { if video.Linearity <some conditon> { <some logic> } ....

Similarly other business logic can be validated into validateOptionalVideoParams

onkarvhanumante · 2024-08-06T11:36:45Z

adapters/insticator/insticator.go

+func toCamelCase(s string) string {
+	if s == "" {
+		return s
+	}
+	return strings.ToLower(string(s[0])) + s[1:]
+}
+
+// Helper function to check if a value is zero or nil
+func isZeroOrNil(value reflect.Value) bool {
+	switch value.Kind() {


based on https://github.com/prebid/prebid-server/pull/3806/files#r1705364786 comment these functions won't be needed

onkarvhanumante · 2024-08-06T11:38:14Z

adapters/insticator/insticator.go

+func toInt(value interface{}) int {
+	switch v := value.(type) {
+	case int:
+		return v
+	case float64:
+		return int(v)
+	case string:
+		if i, err := strconv.Atoi(v); err == nil {
+			return i
+		}
+	}
+	return 0
+}


Based on https://github.com/prebid/prebid-server/pull/3806/files#r1705364786 comment this function is not required.

onkarvhanumante · 2024-08-06T11:38:45Z

adapters/insticator/insticator.go

+func isInteger(value interface{}) bool {
+	switch v := value.(type) {
+	case int:
+		return true
+	case float64:
+		return v == float64(int(v))
+	case string:
+		_, err := strconv.Atoi(v)
+		return err == nil
+	default:
+		return false
+	}
+}
+
+func isArrayOfNums(value interface{}) bool {
+	switch v := value.(type) {


Based on https://github.com/prebid/prebid-server/pull/3806/files#r1705364786 comment this function is not required.

onkarvhanumante · 2024-08-06T11:38:50Z

adapters/insticator/insticator.go

+// Define valid values
+var validLinearity = map[int]bool{1: true}
+var validSkip = map[int]bool{0: true, 1: true}
+var validPlaybackEnd = map[int]bool{1: true, 2: true, 3: true}
+var validPos = map[int]bool{0: true, 1: true, 2: true, 3: true, 4: true, 5: true, 6: true, 7: true}
+
+// Map parameters to validation functions
+var optionalVideoParams = map[string]func(interface{}) bool{
+	"minduration":    isInteger,


Based on https://github.com/prebid/prebid-server/pull/3806/files#r1705364786 comment this function is not required.

onkarvhanumante · 2024-08-06T11:40:45Z

adapters/insticator/insticator.go

+	if responseData.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	if responseData.StatusCode == http.StatusBadRequest {
+		err := &errortypes.BadInput{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}
+
+	if responseData.StatusCode != http.StatusOK {
+		err := &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}


could make use of adapter response utils here

prebid-server/adapters/response.go

Lines 10 to 28 in ec729e6

func CheckResponseStatusCodeForErrors(response *ResponseData) error {

if response.StatusCode == http.StatusBadRequest {

return &errortypes.BadInput{

Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),

}

}

if response.StatusCode != http.StatusOK {

return &errortypes.BadServerResponse{

Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),

}

}

return nil

}

func IsResponseStatusCodeNoContent(response *ResponseData) bool {

return response.StatusCode == http.StatusNoContent

}

onkarvhanumante · 2024-08-06T11:41:33Z

adapters/insticator/insticator.go

+	bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp))
+	bidResponse.Currency = response.Cur


adapters.NewBidderResponseWithBidsCapacity initialises bidResponse.Currency with USD value

consider scenario where bidResponse.Currency is empty, assigning response.Cur directly may set bidResponse.Currency to empty value

consider implementing following changes:

bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(response.SeatBid[0].Bid)) if response.Cur != "" { bidResponse.Currency = response.Cur }

onkarvhanumante · 2024-08-06T11:43:28Z

adapters/insticator/insticator.go

+			if request.Site != nil && i == 0 {
+				populatePublisherId(&impCopy, request)
+			} else if request.App != nil && i == 0 {
+				populatePublisherId(&impCopy, request)
+			}


@shubhamc-ins any particular region to use only request.Imp[0] for populating publisher id?

Is expected behaviour here is to pass same values in Imp.Ext for all impressions part of request. If yes then this should be explicitly mentioned bidder docs. If doc PR doesn't not exist then create it in https://github.com/prebid/prebid.github.io repo

I have updated it.

github-actions · 2024-08-12T13:39:38Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 24d9b39

insticator

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:56:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:64:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:75:	MakeRequests		80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:131:	makeRequest		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:167:	MakeBids		87.5%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:197:	makeImps		84.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:241:	makeReqExt		80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:263:	resolveBidFloor		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:273:	roundTo4Decimals	0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:277:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:292:	populatePublisherId	27.3%
total:										(statements)		72.6%

github-actions · 2024-08-12T14:06:18Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1f43978

insticator

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:56:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:64:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:75:	MakeRequests		77.4%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:133:	makeRequest		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:169:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:201:	makeImps		84.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:245:	makeReqExt		80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:267:	resolveBidFloor		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:277:	roundTo4Decimals	0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:281:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:296:	populatePublisherId	27.3%
total:										(statements)		72.3%

shubhamc-ins · 2024-08-27T17:01:51Z

Hi @onkarvhanumante , Hope you are doing great. Did you get time to re-visit this again?

bsardo · 2024-09-09T15:07:11Z

Hi @shubhamc-ins, I'll see if I can get you a re-review. For the future, please push new commits and merge with master to resolve conflicts instead of rebasing / force pushing. Force pushing requires a lot of extra work on behalf of the reviewers since we need to review everything again instead of just looking at what changed from the last review. All commits on the PR are squashed when merged.

shubhamc-ins · 2024-09-09T15:24:46Z

Hi @shubhamc-ins, I'll see if I can get you a re-review. For the future, please push new commits and merge with master to resolve conflicts instead of rebasing / force pushing. Force pushing requires a lot of extra work on behalf of the reviewers since we need to review everything again instead of just looking at what changed from the last review. All commits on the PR are squashed when merged.

Thanks @bsardo , Got it! Let me know, if you need anything from my side or want me to create a new clean PR ( with new branch ).

shubhamc-ins · 2024-09-30T18:29:29Z

@bsardo Hope you're doing well, did you manage to get some time to get this reviewed again?

In case you need a clean PR again, let me know. Thanks :)

github-actions · 2024-10-03T10:40:23Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c5b5e24

insticator

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:56:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:64:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:75:	MakeRequests		77.4%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:133:	makeRequest		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:169:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:201:	makeImps		84.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:245:	makeReqExt		80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:267:	resolveBidFloor		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:277:	roundTo4Decimals	0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:281:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:296:	populatePublisherId	27.3%
total:										(statements)		72.3%

shubhamc-ins · 2024-10-23T23:20:30Z

Hey @bsardo @onkarvhanumante Please let us know if there is any update or if you got chance to review this again. I have updated the PR with all the requested changes. OR let me know if you guys want a fresh PR, I'll do that (quickly).

I understand you guys must have your hands full but we'd really appreciate, if we can have an estimate since It has been quite a few months that this is opened. I hope you understand.
Also, please resend the confirmation on prebid@insticator.com for the verification of maintainers email.

Thanks a lot.

bsardo · 2024-10-24T14:39:44Z

Hi @shubhamc-ins, @przemkaczmarek and I will take this over and review it. Thanks for your patience.

static/bidder-info/insticator.yaml

adapters/insticator/params_test.go

github-actions · 2024-10-29T19:38:51Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4dfb854

insticator

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:56:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:64:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:75:	MakeRequests		77.4%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:133:	makeRequest		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:169:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:201:	makeImps		84.2%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:245:	makeReqExt		80.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:267:	resolveBidFloor		50.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:277:	roundTo4Decimals	0.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:281:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/insticator/insticator.go:296:	populatePublisherId	27.3%
total:										(statements)		72.3%

bsardo · 2024-11-04T16:18:06Z

Hi @shubhamc-ins, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 so we can resume reviewing. Thanks!

…ticator-bid-adaptor

github-actions · 2024-11-04T16:39:33Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c776f19

insticator

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:56:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:64:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:75:	MakeRequests		77.4%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:133:	makeRequest		50.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:169:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:201:	makeImps		84.2%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:245:	makeReqExt		80.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:267:	resolveBidFloor		50.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:277:	roundTo4Decimals	0.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:281:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v3/adapters/insticator/insticator.go:296:	populatePublisherId	27.3%
total:										(statements)		72.3%

shubhamc-ins · 2024-11-04T16:41:09Z

Hi @shubhamc-ins, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:
import (
    "github.com/prebid/prebid-server/v3/adapters"
)
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 so we can resume reviewing. Thanks!

Hi @bsardo, thanks for the reminder. I have updated the PR with v3 imports.
Please take a look and let me know if you need anything.

Thanks :)

shubhamc-ins and others added 5 commits July 10, 2024 23:59

Update insticator.yaml

56feaa0

add multi-imps testJson (#6)

db6d2c3

Instissp 790 create a basic insticator go lang adapter new (#7)

b751ff9

* add multi-imps testJson * fix pubId parsing for request

update insticator yaml

92e859a

bsardo changed the title ~~New Adaptor: Insticator~~ New Adapter: Insticator Jul 26, 2024

gargcreation1992 assigned onkarvhanumante and Sonali-More-Xandr Aug 6, 2024

onkarvhanumante reviewed Aug 6, 2024

View reviewed changes

update insticator bid adaptor | remove validations | fixed interfaces

24d9b39

shubhamc-ins force-pushed the add-insticator-bid-adaptor branch from c3ab32b to 24d9b39 Compare August 12, 2024 13:38

refactor error checks

1f43978

shubhamc-ins requested a review from onkarvhanumante August 14, 2024 09:49

fix email typo

c5b5e24

bsardo assigned przemkaczmarek and bsardo and unassigned onkarvhanumante and Sonali-More-Xandr Oct 24, 2024

przemkaczmarek self-requested a review October 25, 2024 04:58

przemkaczmarek reviewed Oct 25, 2024

View reviewed changes

static/bidder-info/insticator.yaml Show resolved Hide resolved

przemkaczmarek reviewed Oct 25, 2024

View reviewed changes

adapters/insticator/params_test.go Outdated Show resolved Hide resolved

add invalidparams for insticator

4dfb854

przemkaczmarek previously approved these changes Oct 30, 2024

View reviewed changes

shubhamc-ins added 2 commits November 4, 2024 22:04

Merge branch 'master' of github.com:prebid/prebid-server into add-ins…

713599c

…ticator-bid-adaptor

update imports to v3 for insticator

c776f19

shubhamc-ins dismissed przemkaczmarek’s stale review via c776f19 November 4, 2024 16:38

		@@ -0,0 +1,17 @@
		endpoint: "https://ex.ingage.tech/v1/prebidserver"

	var validPlaybackEnd = map[int]bool{1: true, 2: true, 3: true}
	var validPos = map[int]bool{0: true, 1: true, 2: true, 3: true, 4: true, 5: true, 6: true, 7: true}

	// Map parameters to validation functions
	var optionalVideoParams = map[string]func(interface{}) bool{
	"minduration": isInteger,

	func CheckResponseStatusCodeForErrors(response *ResponseData) error {
	if response.StatusCode == http.StatusBadRequest {
	return &errortypes.BadInput{
	Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),
	}
	}

	if response.StatusCode != http.StatusOK {
	return &errortypes.BadServerResponse{
	Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),
	}
	}

	return nil
	}

	func IsResponseStatusCodeNoContent(response *ResponseData) bool {
	return response.StatusCode == http.StatusNoContent
	}

		bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp))
		bidResponse.Currency = response.Cur

New Adapter: Insticator #3806

Are you sure you want to change the base?

New Adapter: Insticator #3806

Conversation

shubhamc-ins commented Jul 10, 2024 • edited Loading

github-actions bot commented Jul 10, 2024

Code coverage summary

insticator

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onkarvhanumante Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onkarvhanumante Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

onkarvhanumante Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onkarvhanumante Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 12, 2024

Code coverage summary

insticator

github-actions bot commented Aug 12, 2024

Code coverage summary

insticator

shubhamc-ins commented Aug 27, 2024

bsardo commented Sep 9, 2024

shubhamc-ins commented Sep 9, 2024

shubhamc-ins commented Sep 30, 2024 • edited Loading

github-actions bot commented Oct 3, 2024

Code coverage summary

insticator

shubhamc-ins commented Oct 23, 2024 • edited Loading

bsardo commented Oct 24, 2024

github-actions bot commented Oct 29, 2024

Code coverage summary

insticator

bsardo commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

Code coverage summary

insticator

shubhamc-ins commented Nov 4, 2024 • edited Loading

shubhamc-ins commented Jul 10, 2024 •

edited

Loading

onkarvhanumante Aug 6, 2024 •

edited

Loading

onkarvhanumante Aug 6, 2024 •

edited

Loading

onkarvhanumante Aug 6, 2024 •

edited

Loading

onkarvhanumante Aug 6, 2024 •

edited

Loading

shubhamc-ins commented Sep 30, 2024 •

edited

Loading

shubhamc-ins commented Oct 23, 2024 •

edited

Loading

shubhamc-ins commented Nov 4, 2024 •

edited

Loading