-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #180
base: master
Are you sure you want to change the base?
Integration tests #180
Conversation
0c446a5
to
dbe7a19
Compare
dbe7a19
to
24b30a7
Compare
The biggest issue with this PR is that running tests is aleatory. Basically, all tests may fail because of network, cpu, bandwith, google deciding that we're overcalling their endpoint, and other thousand million causes that it'll be impossible to say "oh, tests are failing because it's my fault". Another issue is that these tests take several minutes to run. On a local pc they may take up to 5-6 minutes. So they're only suitable for a CI environment. So, probably if we remove some tests, or some browsers, and we keep the run timing under 2 minutes, and we tweak the parameters so that tests failing go to zero, this is the test suite we were missing |
Integration tests; this aims to be exhaustive, but is a WIP.
Cases covered so far:
nurl
#183) , trigger nurl/burl/wurl)AD_RENDER_SUCCEEDED
/AD_RENDER_FAILED
#182 )In progress:
Missing:
native-trk.js
(need examples/docs!)Not supported by PUC (!)