Skip to content

Commit

Permalink
fix: a11y improvements (#155)
Browse files Browse the repository at this point in the history
* fix: move totals to a separate table

* fix: don't consider current institution on duplicate name check

* fix: tests for duplicate institution name

* fix: book limit input accessibility

* feat: add feature tests for InstitutionsTable

* fix: attempt to inject content immediately after page load

* fix: update message in the assign books page

* fix: clean up db after each test

* fix: merge conflict

* fix: improve institutionsTotals class

* fix: inject alert content after page load

* fix: full size table for smaller screens

* chore: bump dependencies

* fix: add `error-list` class back

* fix: remove `is-dismissible` class

* fix: remove `role` attribute since WP adds it dynamically

* fix: add `type="text"`

* fix: replace title with screen reader information

---------

Co-authored-by: Felipe Dalcin <felipe@pressbooks.com>
Co-authored-by: Oscar Arzola <oscararzola@gmail.com>
  • Loading branch information
3 people authored Apr 11, 2024
1 parent a4297d3 commit b9230da
Show file tree
Hide file tree
Showing 21 changed files with 407 additions and 399 deletions.
75 changes: 38 additions & 37 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/assets/pressbooks-multi-institution-34e9eba8.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion dist/assets/pressbooks-multi-institution-6c8c8aa3.css

This file was deleted.

6 changes: 3 additions & 3 deletions dist/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
"src": "node_modules/@pressbooks/multiselect/pressbooks-multiselect.js"
},
"resources/assets/js/pressbooks-multi-institution.css": {
"file": "assets/pressbooks-multi-institution-6c8c8aa3.css",
"file": "assets/pressbooks-multi-institution-34e9eba8.css",
"src": "resources/assets/js/pressbooks-multi-institution.css"
},
"resources/assets/js/pressbooks-multi-institution.js": {
"css": [
"assets/pressbooks-multi-institution-6c8c8aa3.css"
"assets/pressbooks-multi-institution-34e9eba8.css"
],
"file": "assets/app-f5d07064.js",
"file": "assets/app-81345697.js",
"isEntry": true,
"src": "resources/assets/js/pressbooks-multi-institution.js"
}
Expand Down
Loading

0 comments on commit b9230da

Please sign in to comment.