Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map object to WP_User class #187

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

fdalcin
Copy link
Contributor

@fdalcin fdalcin commented Jul 11, 2024

Fix for pressbooks/private#1476

This PR fixes an issue where when editing an institution, the Institutional Managers assigned to that institution don't show as selected in the page.

How to test

  1. With the dev branch selected, create an institution and assign one or more institutional managers
  2. The Institution List should display the assigned institutional managers correctly
  3. Click on the edit page. You should not see the Institutional Managers selected in the input
  4. Switch to this branch and reload the page. You should now see the Institutional Managers as before
  5. Click save and make sure the Institution is updating, persisting the selected Institutional Managers

Copy link
Contributor

@richard015ar richard015ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richard015ar richard015ar merged commit b8213aa into dev Jul 11, 2024
@richard015ar richard015ar deleted the fix/map-object-to-wp-user branch July 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants