Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assign users order #37

Merged
merged 11 commits into from
Feb 13, 2024
Merged

fix: assign users order #37

merged 11 commits into from
Feb 13, 2024

Conversation

richard015ar
Copy link
Contributor

This PR addresses: #15 (comment)

Testing case

  • in Assign Users page apply order and/or search on the table.
  • Assign 1 or more users to an institution through the bulk action. You can unassign a user also.
  • Make sure after the assignment/unassigment the order/search persists.

fdalcin
fdalcin approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@fdalcin fdalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @richard015ar

I pushed a friendly with a simple adjustment.

@fdalcin fdalcin merged commit 95c836a into dev Feb 13, 2024
6 checks passed
@fdalcin fdalcin deleted the fix/assign-users-order branch February 13, 2024 19:51
@pressbooks-ops pressbooks-ops mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdalcin fdalcin fdalcin approved these changes

Assignees

@fdalcin fdalcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard015ar @fdalcin