Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTTP Status Code 208 - Already Reported #75

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RonakR
Copy link

@RonakR RonakR commented Sep 2, 2021

Added HTTP Status Code 208 - Already Reported

@RonakR
Copy link
Author

RonakR commented Sep 14, 2021

@prettymuchbryce is this good to go?

Copy link

@pacifiquem pacifiquem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTP Status Code 208 means that the members of a DAV binding have already been enumerated in a preceding part of the multi-status response, and are not being included again.

This is good to go @prettymuchbryce

@pacifiquem
Copy link

@RonakR Would you mind resolving these conflicts so that the maintainers can merge your pull request?

@pacifiquem
Copy link

now we're ready to go @prettymuchbryce

@prettymuchbryce
Copy link
Owner

Would it be possible to revert all changes except to codes.json? I can compile the other files as part of the next release.

@pacifiquem
Copy link

Sure @prettymuchbryce let @RonakR work on it.

@renatoaraujo
Copy link

Any updates on this one? Cheers!

@RonakR
Copy link
Author

RonakR commented Jan 5, 2024

Updated. Lmk if anything else is needed @prettymuchbryce @pacifiquem

@pacifiquem
Copy link

Now it Looks good to me 👍

@prettymuchbryce
Copy link
Owner

Please revert the package lock changes. After that it LGTM.

@YuliyaNovik
Copy link

hi @RonakR!
do you plan to update this PR anytime soon?

@RonakR
Copy link
Author

RonakR commented Jul 23, 2024

@prettymuchbryce package lock changes reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants