Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARE-1802] Refactor - Extensions model #504

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

[CARE-1802] Refactor - Extensions model #504

wants to merge 55 commits into from

Conversation

e1himself
Copy link
Contributor

No description provided.

@e1himself
[CARE-1802] Provide infra for extensions definitions
05fb71b
@e1himself
[CARE-1802] Allow passing multiple extensions to register() and `us…
d5dc2c8 
…eExtendEditor()`
@e1himself
[CARE-1802] Use shallow compare for registering extensions
0c38071
@e1himself
[CARE-1802] Convert existing extensions to React components
4770f5f 
Each using the `useRegisterExtension()` hook to wire into the editor functionality.

� Conflicts:
�	packages/slate-editor/src/extensions/file-attachment/FileAttachmentExtension.tsx
�	packages/slate-editor/src/extensions/galleries/GalleriesExtension.tsx
�	packages/slate-editor/src/extensions/image/ImageExtension.tsx
�	packages/slate-editor/src/extensions/loader/LoaderExtension.tsx
@e1himself
[CARE-1802] Convert getEnabledExtensions() to a React component
07cb9ad 
Conflicts:
- packages/slate-editor/src/modules/editor/getEnabledExtensions.ts

� Conflicts:
�	packages/slate-editor/src/modules/editor/Editor.tsx
�	packages/slate-editor/src/modules/editor/getEnabledExtensions.ts
@e1himself
[CARE-1802] Move variables UI markup and state to VariablesExtension
1f636e3
@e1himself
[CARE-1802] Move user mentions UI markup and state to `UserMentionsEx…
4164b89 
…tension`
@e1himself
[CARE-1802] Render Extensions inside <Slate> context
7d90896 
� Conflicts:
�	packages/slate-editor/src/modules/editor/Editor.tsx
@e1himself
[CARE-1802] Simplify onKeyDown prop handling
1c6ef3a 
No need to do the `onKeyDownList` & `onKeyDownDeps` yada-yada
@e1himself
[CARE-1802] Consolidate Snippets UI and state in the SnippetsExtensio…
8d2a5e3 
…n folder

� Conflicts:
�	packages/slate-editor/src/extensions/snippet/SnippetsExtension.tsx
@e1himself
[CARE-1802] Solve onChange callback for UserMentions & Variables ex…
f52b0a9 
…tensions
@e1himself
[CARE-1802] Comment out broken code
f0f4467
@e1himself
[CARE-1802] Improve error message
5a93734
@e1himself
[CARE-1802] Move FlashNodes rendering to the FlashNodesExtension
94e5661
@e1himself
[CARE-1802] Optimize TextStylingExtension by ensuring referential equ…
f5a05fb 
…ality
@e1himself
[CARE-1802] Reogranize Extensions manager module
e4f434e
@e1himself
[CARE-1802] Rewrite ExtensionsManager to keep editor.extensions up …
8ec34b5 
…to date
@e1himself
[CARE-1802] Move RichFormattingMenu UI into the new `RichFormattingMe…
825e855 
…nuExtension`

� Conflicts:
�	packages/slate-editor/src/modules/editor/Editor.tsx
�	packages/slate-editor/src/modules/editor/Extensions.tsx
@e1himself
[CARE-1802] Finish transitioning of SnippetsExtension to be self-suff…
5b48268 
…icient UI component

Related to 8d2a5e3

� Conflicts:
�	packages/slate-editor/src/extensions/snippet/SnippetsExtension.tsx
�	packages/slate-editor/src/modules/editor/Extensions.tsx
@e1himself
[CARE-1802] Leave comments for later
9e02f82 
� Conflicts:
�	packages/slate-editor/src/modules/editor/Editor.tsx
@e1himself
[CARE-1802] Wire EditableWithExtensions to the editor extensions prop…
106006e 
…erty
@e1himself
[CARE-1802] Move editor.serialization() functionality to the Extens…
660332f 
…ionsEditor definition
@e1himself
[CARE-1802] Move editor.isElementEqual() functionality to the Exten…
6b36e1b 
…sionsEditor definition
@e1himself
[CARE-1802] Move editor.isInline() & editor.isVoid() extensions o…
9754158 
…verrides to the ExtensionsEditor definition
@e1himself
[CARE-1802] Move editor.normalizeNode() extensions overrides to the…
bc19448 
… ExtensionsEditor definition
@e1himself
[CARE-1802] Move editor.isRichBlock() extensions checks to the Exte…
77ee360 
…nsionsEditor definition
@e1himself
[CARE-1802] Provide a way for extensions to hook into `editor.insertD…
4c033e4 
…ata()` function
@e1himself
[CARE-1802] Extract Paste event tracking into a separate extension
d38af1d
@e1himself
[CARE-1802] Rewrite Slate Pasting extension to the new insertData()…
f23d4b9 
… hook

Without relying on `withOverrides()`

� Conflicts:
�	packages/slate-editor/src/extensions/paste-slate-content/lib/withSlatePasting.ts
�	packages/slate-editor/src/modules/editor/Extensions.tsx
@e1himself
[CARE-1802] Deprecate withOverrides()
6d2a1a4
@e1himself
[CARE-1802] Convert withDeserializeHtml editor mutator function to …
1b5485d 
…an Extension

� Conflicts:
�	packages/slate-editor/src/modules/editor/createEditor.ts
�	packages/slate-editor/src/modules/editor/plugins/index.ts
�	packages/slate-editor/src/modules/editor/plugins/withDeserializeHtml/withDeserializeHtml.ts
@e1himself
[CARE-1802] Rewrite Images & Files pasting to the new insertData() …
0dbf508 
…extension hook

Instead of relying on the hard-to-maintain `withOverrides` extension feature

� Conflicts:
�	packages/slate-editor/src/extensions/loader/index.ts
�	packages/slate-editor/src/extensions/loader/transforms/index.ts
�	packages/slate-editor/src/extensions/loader/transforms/insertUploadingFile.ts
�	packages/slate-editor/src/extensions/paste-files/PasteFilesExtension.ts
�	packages/slate-editor/src/extensions/paste-files/lib/index.ts
�	packages/slate-editor/src/extensions/paste-images/PasteImagesExtension.ts
�	packages/slate-editor/src/extensions/paste-images/lib/index.ts
@e1himself
[CARE-1802] Replace withResetFormattingOnBreak editor mutator with …
07a8cd6 
…new `insertBreak` extension hooks
@e1himself
[CARE-1802] Add a todo
a3627f2
@e1himself
[CARE-1802] Rewrite LinksExtension autolinking handling to `insertDat…
454673d 
…a()` hooks
@e1himself
[CARE-1802] Convert withPastedUrlsUnfurling mutator to insertData…
a5603de 
… hook
@e1himself
[CARE-1802] Add an extension hook into editor.insertText() method
c0846c1
@e1himself
[CARE-1802] Rewrite withAutoformat editor mutator to insertText()…
698fb74 
… hook
@e1himself
[CARE-1802] Add a way to hook into HistoryEditor undo() and `redo…
b3d6c8a 
…()` methods
@e1himself
[CARE-1802] Simplify event-tracking callbacks
1264170 
Consolidate file attachments management inside `FileAttachmentExtension` module

� Conflicts:
�	packages/slate-editor/src/extensions/paste-files/lib/createDataTransferHandler.ts
�	packages/slate-editor/src/extensions/placeholders/PlaceholdersManager.ts
�	packages/slate-editor/src/extensions/placeholders/elements/AttachmentPlaceholderElement.tsx
�	packages/slate-editor/src/extensions/placeholders/index.ts
�	packages/slate-editor/src/modules/events/types.ts
@e1himself
[CARE-1802] Add an extension hook into editor.setFragmentData() method
8a02a3a
@e1himself
[CARE-1802] Convert withImages() editor mutator plugin to `setFragm…
dfef2fa 
…entData()` hook
@e1himself e1himself self-assigned this Sep 19, 2023
@e1himself e1himself mentioned this pull request Sep 21, 2023
Closed
@e1himself
Merge branch 'refactor/care-1802-drop-loader-extension' into x/care-1…
f5b8b84 
…802-extensions-model

# Conflicts:
#	packages/slate-editor/src/extensions/paste-files/lib/withFilesPasting.ts
#	packages/slate-editor/src/extensions/paste-images/lib/withImagesPasting.ts
@e1himself
[CARE-1802] Change ListExtension to work without withOverrides
461f292
@e1himself
[CARE-1802] Add a hook to Editor.getFragment() method
7c4f889
@e1himself
[CARE-1802] Export table plugin's editor overrides as separate parts
70418c6
@e1himself
[CARE-1802] Add hooks for Editor deleteBackward() and `deleteForwar…
a5bf2f5 
…d()` methods
@e1himself
[CARE-1802] Change TablesExtension to work without withOverrides …
de130cd 
…call
@e1himself
[CARE-1802] Fix TS type error
af19597
@e1himself
[CARE-1802] Rewrite FlashNodesExtension to work without `withOverri…
30c054a 
…des`
@e1himself
[CARE-1802] Completely drop Extension.withOverrides() feature
144d476 
It's no longer used by any of the extensions
@e1himself
[CARE-1802] Fix useRegisterExtension effect dependencies
1f8606a
@e1himself
[CARE-1802] Make ExtensionsEditor code type-strict to catch possible …
9552dac 
…human errors
@e1himself
[CARE-1802] Update editor factory to not require extensions or `plu…
fff36d8 
…gins` from outside
@e1himself
[CARE-1802] Rewrite ExtensionsManager to not trigger a re-render on e…
cf84124 
…xtension method hooks changes
Base automatically changed from refactor/care-1802-drop-loader-extension to main December 12, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@e1himself e1himself

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@e1himself