[CARE-6013] Feature - Refetch coverage when update event happens #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
reviewed
Sep 17, 2024
Comment on lines
63
to
71
| function handleCoverageUpdated({ coverage }: { coverage: Pick<CoverageEntry, 'id'>}) { | ||
| if (element.coverage.id === coverage.id) { | ||
| loadCoverage(); | ||
| } | ||
| } | ||
|
|
||
| useEffect(() => { | ||
| EventsEditor.addEventListener(editor, 'coverage-updated', handleCoverageUpdated); | ||
| }, []); |
There was a problem hiding this comment.
- Shouldn't
handleCoverageUpdatedbe a local function to the effect callback? - Should it not remove the event listener in the effect unmount callback?
There was a problem hiding this comment.
You're right, I forgot 🙂
e1himself
approved these changes
Sep 17, 2024
kudlajz
deleted the
feature/care-6013-coverage-card-data-not-updated-immediately
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.