-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATFORM-2230]: Create an MVP for webkit support #1
[PLATFORM-2230]: Create an MVP for webkit support #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment that much on the Rust code itself, the question I have is with maintenability
- We have Nix, which not many people in Prima are familiar with
- We have "complex" Rust code
The second thing could probably be improved with more documentation, the first one I don't know... I don't want to kill the Nix dream but it is something we need to consider
That said, really nice job and really clean code 😄
yeahhh, but the alternative for our use case was to make a debian package, which I don't know how to do myself, and I don't think many more people at prima know how to.
yeahhhh, this is interacting with GTK so not much can be done in terms of fixing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the code part it seems ok to me. I didn't even took a look at the nix part :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine for an MVP, if the Nix or Rust code can be documented better let's do that otherwise it's ok
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-2230
this is very unfinished and could use a bunch of refactors but it's good enough for an mvp