-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Send alert messages on handshake failures
When SSL_do_handshake() fails we should send data even when SSL_ERROR_WANT_WRITE is not reported (because a final error such as "unsupported protocol" is reported). If we don't do it, we don't send handshake alerts toward the peer and as a consequence: - We formally violate RFC 5246, appendix E.1: > If server supports (or is willing to use) only versions greater > than client_version, it MUST send a "protocol_version" alert message > and close the connection. - We are complicating the debugging of the protocol. - We don't give a hint to a peer on how to proceed with the error. This commit fixes it.
- Loading branch information
Evgeny Khramtsov
committed
Jan 9, 2024
1 parent
4ae9adf
commit f83322c
Showing
2 changed files
with
19 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters