BREAKING: Use a single Node.js version for test & publish #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/node-versions
branch
from
8486f12
to
a53b0c3
Compare
|
Website deployed to CF Pages, 👀 preview link https://831c0d96.flowzone.pages.dev |
klutchell
force-pushed
the
kyle/node-versions
branch
from
a53b0c3
to
c8d1a14
Compare
klutchell
changed the title
Projects should be opinionated and define the desired node version in .node_version in the root of the project. This is supported natively via the setup-node action to and renovate to auto-detect the version to use. Failing this, we will still fall back to testing with recent LTS releases but only select the first compatible version detected, in decending order (newest first). Change-type: major Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
kyle/node-versions
branch
from
9c48b5c
to
5142d23
Compare
|
Discussed with the team and the gains by dropping some Node.js test variants would be negligible while we would lose valuable test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects should be opinionated and define the desired node version in .node_version in the root of the project. This is supported natively via the setup-node action to and renovate to auto-detect the version to use.
Failing this, we will still fall back to testing with recent LTS releases but only select the first compatible version detected, in decending order (newest first).
Change-type: major
See: https://balena.fibery.io/Work/Improvement/Test-Node.js-projects-against-a-single-version-2262