Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

about #2

wants to merge 2 commits into from

Conversation

jayandon
Copy link

I was working with Paulina Dabrowska



<div class="location">
<b><h1>LOCATION</h1></b>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not valid to have the <b> element around the <h1>
Generally my advice is that if you find yourself wanting to put one of the inline elements like b, i, em or strong around the entire contents of another element, then instead you should give a class to that element and style it with the class. Reserve the inline elements for when you just want to style part of the content.

Also, unless you are going to change the div to section then I would recommend changing these h1s to h2. Either way you should still add a class to each major section/div so you can more easily style that section and its contents. If your class name was info then you could style the h2s like:

.section h2{
 font-weight: 900;
 text-transform: uppercase;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants