Install the Stripe CLI alongside the commands - #22
Merged
Conversation
The payment work needs the Stripe CLI on every box, and "install the Stripe CLI first" is the setup step that quietly never happens. The installer now fetches the official binary from stripe/stripe-cli. It follows the codeburn precedent: vendored under vendor/stripe so the name exists once, then linked into the prefix. A stripe already on PATH from a package manager wins and nothing is linked over it. The step runs after the commands are linked and warns instead of dying. An unknown architecture, a GitHub outage or a rate-limited API lookup should not fail an install that has otherwise already succeeded, so each of those paths says why and returns. The version falls back to the last one verified against this installer when the API cannot be reached. The published sha256 is checked. It comes from the same host as the tarball so it is not a supply-chain guarantee, but it catches the truncated download that this will actually see. Verified on linux/x86_64: downloads 1.50.4, links it, `stripe --version` runs, and a second run is a no-op. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan6 finding(s) MEDIUM: 1 | LOW: 5
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payment work needs the Stripe CLI on every box, and "install the Stripe CLI first" is the setup step that quietly never happens.
install.shnow fetches the official binary fromstripe/stripe-cli.Shape
Follows the codeburn precedent — vendored under
vendor/stripeso the name exists once, then linked into the prefix. Astripealready on PATH from a package manager wins, and nothing is linked over it.The step runs after the commands are linked and warns instead of dying. An unknown architecture, a GitHub outage, or a rate-limited API lookup shouldn't fail an install that has otherwise already succeeded, so each of those paths says why and returns. The version falls back to the last one verified against this installer when the API can't be reached.
The published sha256 is checked. It comes from the same host as the tarball, so it isn't a supply-chain guarantee — it catches the truncated download this will actually see.
Knobs
STRIPE_CLI_VERSIONpins a versionCLI_TOOLS_SKIP_STRIPE=1skips it entirelyVerified
On linux/x86_64: downloads 1.50.4, checksums it, links it,
stripe --versionreports1.50.4, and a second run printsalready installedwithout re-downloading.sh -n install.shis clean.🤖 Generated with Claude Code