Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/relative imports #41

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix/relative imports #41

merged 2 commits into from
Sep 20, 2023

Conversation

felipebergamin
Copy link
Member

Description

Some imports were using absolute imports to lib/ dir, this was causing issues when using the published package because node isn't able to resolve this imports.

Related Issues

Progress

Pull request checklist

  • Tests: This PR includes tests for covering the features or bug fixes (if applicable).
  • Docs: This PR updates/creates the necessary documentation.
  • CI: Make sure your Pull Request passes all CI checks. If not, clarify the motif behind that and the action plan to solve it (may reference a ticket)

How to test it

Visual reference

@felipebergamin felipebergamin merged commit f96030d into master Sep 20, 2023
2 checks passed
@felipebergamin felipebergamin deleted the fix/relative-imports branch September 20, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants