Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qemu-system-aarch64 capabilities #21

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ashwing123
Copy link
Contributor

Included a new default config for aarch64 platforms and obtained appropriate paths. Also using project-machine/qcli instead of raharper/qcli.

Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to tidy up in comments.

Thanks! It's really gratifying to see how little machine needed to bring up arm64 qemu via the qcli changes.

go.mod Outdated Show resolved Hide resolved
pkg/api/qconfig.go Outdated Show resolved Hide resolved
@ashwing123
Copy link
Contributor Author

Fixed above issues :)

Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase and squash into single commit please?

… as dep

Included a new default config for aarch64 platforms and obtained appropriate paths. Changed dependency from raharper/qcli to project-machine/qcli wherever applicable.
@ashwing123
Copy link
Contributor Author

Rebased and squashed

@raharper raharper merged commit 242272d into project-machine:main Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants