Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import UEFI Code file if specified in machine yaml #26

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

raharper
Copy link
Collaborator

@raharper raharper commented Sep 6, 2023

Due to different sized (and possibly incompatible firmware changes)
machine definitions allow specifying a UEFI Code blob as well as the
vars. UEFI Code and Vars should be delivered in pairs and imported
as such.

  • add --debug flag to init subcommand
  • make sure to check error returned from checkMachineFilePaths
  • run gofmt on touched files

Fixes: #25

Signed-off-by: Ryan Harper <rharper@woxford.com>
Due to different sized (and possibly incompatible firmware changes)
machine definitions allow specifying a UEFI Code blob as well as the
vars.  UEFI Code and Vars should be delivered in pairs and imported
as such.

Signed-off-by: Ryan Harper <rharper@woxford.com>
@raharper raharper requested a review from hallyn September 6, 2023 16:24
Copy link
Contributor

@hallyn hallyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now I just need to update some mos testcases to use it.

@raharper raharper merged commit 792a924 into project-machine:main Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No console output with 9ebadddf962ca080de77ef2fc5da1e06665ee949
2 participants