Use shadow buffers for scanning out and GPU blit engine to copy content before present #82
+915
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
feijiang1,
gkdeepa,
renchenglei,
YuanjunHuang and
yyao3
feijiang1
reviewed
Sep 9, 2024
There was a problem hiding this comment.
great implementation
@HaihongxLi @manxiaoliang please review together
feijiang1
reviewed
Sep 9, 2024
feijiang1
reviewed
Sep 9, 2024
| char device_path[32]; | ||
| if (fd >= 0) | ||
| return fd; | ||
| for (int i = 0; i < 64; ++i) { |
There was a problem hiding this comment.
64 seems too big, normally we didn't have such many devices
feijiang1
reviewed
Sep 9, 2024
feijiang1
reviewed
Sep 9, 2024
|
Improper Commit Message |
|
Improper Commit Message |
|
The performance is much more satisfying with XY_FAST_COPY_BLT instruction now. Thus I suppose we can merge it if it won't lead to any regression. @HaihongxLi @manxiaoliang @feijiang1 @xzhan34 Please review it. |
feijiang1
reviewed
Oct 14, 2024
feijiang1
reviewed
Oct 14, 2024
feijiang1
reviewed
Oct 14, 2024
To get best performance we must guarantee that scan-out buffers used for composition in surfaceflinger reside in GPU local memory, but importing these buffers into virtio-GPU will migrate the buffers from local memory to system memory, which will highly impact the performance. To avoid migration of these client-composited buffers, allocate a shadow buffer for each of them and import the shadow buffers into virtio-GPU for scanning-out. Right before atomic commit, leverage GPU blit engine to copy content to shadow buffer. Use shadow buffers only when feature ALLOW_P2P of virtio-GPU is not present and dGPU exists. There are several GPU instructions to blit memory: - XY_FAST_COPY_BLT (BSpec: 47982), - XY_SRC_COPY_BLT (BSpec: 48002), - XY_BLOCK_COPY_BLT (BSpec: 3678). By experiment, XY_FAST_COPY is much faster than the other two instructions. Tracked-On: OAM-124182 Signed-off-by: Weifeng Liu <weifeng.liu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.