BACKPORT: perf_event: Add support for LSM and SELinux checks #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current mainline, the degree of access to perf_event_open(2) system
call depends on the perf_event_paranoid sysctl. This has a number of
limitations:
based on the single value thus making the control very limited and
coarse grained.
all processes get access to perf_event_open(2) opening the door to
security issues.
This patch adds LSM and SELinux access checking which will be used in
Android to access perf_event_open(2) for the purposes of attaching BPF
programs to tracepoints, perf profiling and other operations from
userspace. These operations are intended for production systems.
5 new LSM hooks are added:
perf_event_open: This controls access during the perf_event_open(2)
syscall itself. The hook is called from all the places that the
perf_event_paranoid sysctl is checked to keep it consistent with the
systctl. The hook gets passed a 'type' argument which controls CPU,
kernel and tracepoint accesses (in this context, CPU, kernel and
tracepoint have the same semantics as the perf_event_paranoid sysctl).
Additionally, I added an 'open' type which is similar to
perf_event_paranoid sysctl == 3 patch carried in Android and several other
distros but was rejected in mainline [1] in 2016.
perf_event_alloc: This allocates a new security object for the event
which stores the current SID within the event. It will be useful when
the perf event's FD is passed through IPC to another process which may
try to read the FD. Appropriate security checks will limit access.
perf_event_free: Called when the event is closed.
perf_event_read: Called from the read(2) and mmap(2) syscalls for the event.
perf_event_write: Called from the ioctl(2) syscalls for the event.
[1] https://lwn.net/Articles/696240/
Since Peter had suggest LSM hooks in 2016 [1], I am adding his
Suggested-by tag below.
To use this patch, we set the perf_event_paranoid sysctl to -1 and then
apply selinux checking as appropriate (default deny everything, and then
add policy rules to give access to domains that need it). In the future
we can remove the perf_event_paranoid sysctl altogether.
Suggested-by: Peter Zijlstra peterz@infradead.org
Co-developed-by: Peter Zijlstra peterz@infradead.org
Signed-off-by: Joel Fernandes (Google) joel@joelfernandes.org
Signed-off-by: Peter Zijlstra (Intel) peterz@infradead.org
Acked-by: James Morris jmorris@namei.org
Cc: Arnaldo Carvalho de Melo acme@kernel.org
Cc: rostedt@goodmis.org
Cc: Yonghong Song yhs@fb.com
Cc: Kees Cook keescook@chromium.org
Cc: Ingo Molnar mingo@redhat.com
Cc: Alexei Starovoitov ast@kernel.org
Cc: jeffv@google.com
Cc: Jiri Olsa jolsa@redhat.com
Cc: Daniel Borkmann daniel@iogearbox.net
Cc: primiano@google.com
Cc: Song Liu songliubraving@fb.com
Cc: rsavitski@google.com
Cc: Namhyung Kim namhyung@kernel.org
Cc: Matthew Garrett matthewgarrett@google.com
Link: https://lkml.kernel.org/r/20191014170308.70668-1-joel@joelfernandes.org
Bug: 137092007
(cherry picked from commit da97e18458fb42d7c00fac5fd1c56a3896ec666e)
[ Ryan Savitski: resolved merge conflicts with perf_event_paranoid=3 code ]
Signed-off-by: Ryan Savitski rsavitski@google.com
[ Ryan Savitski: Folded in upstream ae79d5588a04 (perf/core: Fix
!CONFIG_PERF_EVENTS build warnings and failures). This should fix the
build errors from the previous backport attempt, where certain
configurations would end up with functions referring to the perf_event
struct prior to its declaration (and therefore declaring it with a
different scope). ]
Signed-off-by: Ryan Savitski rsavitski@google.com
Change-Id: I50769ede23fbfd8996657c6dae99cab98a3042bc