Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sensors aidl patches to main repo UMR0 #128

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Merge sensors aidl patches to main repo UMR0 #128

merged 5 commits into from
Nov 8, 2023

Conversation

RajaniRanjan
Copy link
Contributor

@RajaniRanjan RajaniRanjan commented Oct 26, 2023 •
edited
Loading

Merge sensors aidl patches to main repo UMR0
OAM-112804

@RajaniRanjan
google default implementation for Sensor aidl.
3ba866e 
to implement the Sensors AIDL HAL, an object must extend
the ISensors interface and implement all functions defined
in hardware/interfaces/sensors/aidl/android/hardware/sensors/ISensors.aidl

Tracked-On: OAM-112804
Signed-off-by: Ranjan, Rajani <rajani.ranjan@intel.com>
@RajaniRanjan
Sensors HAL : Update to AIDL implementation.
b72c2f2 
The minimum requirement for Sensors HAL in android 14 should be AIDL
implementation to meet target-level 8, API level 34 requirement.
upgrading to AIDL  implementations.

moving from Sensors2.0 HIDL service to Sensors AIDL service HAL, which is based on
Sensors HAL 2.1, uses the AIDL HAL interface.
Sensors AIDL HAL is available in Android 13 and higher for new
and upgraded devices.

Tracked-On: OAM-112804
Signed-off-by: Ranjan, Rajani <rajani.ranjan@intel.com>
@RajaniRanjan
changing sensors@aidl to version_2 in manifest.xml to inline with com…
7055c30 
…patibilty matrix.

google compatibility matrix for android u requires sensors@aidl version 2.
android.hardware.sensors@2.0::ISensors/default is deprecated in
compatibility matrix at FCM Version 8.
The minimum requirement for Sensors HAL in android 14 should be AIDL
implementation to meet target-level 8, API level 34 requirement.

Tracked-On: OAM-112804
Signed-off-by: Ranjan, Rajani <rajani.ranjan@intel.com>
@RajaniRanjan
adding debug logs for AIDL sensors HAL.
3f2748e 
Tracked-On: OAM-112804
Signed-off-by: Ranjan, Rajani <rajani.ranjan@intel.com>
@RajaniRanjan
fixing DEBUG variable value to enable/disable logs
5c08f61 
Tracked-On: OAM-112804
Signed-off-by: Ranjan, Rajani <rajani.ranjan@intel.com>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

2 similar comments
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@RajaniRanjan RajaniRanjan changed the title Merge sensors aidl patches to main repo UNR0 Merge sensors aidl patches to main repo UMR0 Oct 26, 2023
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

3 similar comments
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

8 similar comments
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

vilasrk
vilasrk approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@vilasrk vilasrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

balajim001
balajim001 approved these changes Nov 7, 2023
View reviewed changes
Copy link

@balajim001 balajim001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci removed the request for review from JeevakaPrabu November 7, 2023 09:07
sysopenci
sysopenci reviewed Nov 7, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:Trigger Builds cancelled

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/5276

sysopenci
sysopenci reviewed Nov 8, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'preintegration' builder

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/5282

Done by "Ranjan, Rajani" rajani.ranjan@intel.com

sysopenci
sysopenci reviewed Nov 8, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'premerge' builder

More details, logs, and binaries: /absp/builders/celadon-premerge/builds/3068

Done by "Ranjan, Rajani" rajani.ranjan@intel.com

@sysopenci sysopenci merged commit eddd832 into projectceladon:master Nov 8, 2023
17 checks passed
sysopenci
sysopenci reviewed Nov 8, 2023
View reviewed changes
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cactus finished building and testing your changes

It was requested for merge by "Ranjan, Rajani" rajani.ranjan@intel.com

so we merge it. Thanks for your contribution.

more details, logs, and binaries: /absp/builders/celadon-mergerequest/builds/3425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysopenci sysopenci sysopenci left review comments

@sgnanase sgnanase sgnanase approved these changes

@balajim001 balajim001 balajim001 approved these changes

@vilasrk vilasrk vilasrk approved these changes

Assignees
No one assigned
Labels
PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RajaniRanjan @sysopenci @sgnanase @balajim001 @vilasrk