Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIDL Conversion of Thermal HAL. #130

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

vilasrk
Copy link
Collaborator

@vilasrk vilasrk commented Oct 31, 2023

This change will convert Thermal HAL from HIDL to AIDL

Test:
adb shell dumpsys thermalservice.

Current temperatures from HAL:
Temperature{mValue=65.0, mType=0, mName=TCPU, mStatus=0}
Temperature{mValue=25.0, mType=1, mName=test sensor, mStatus=0}
Temperature{mValue=25.0, mType=2, mName=TBATTERY, mStatus=0}

Current cooling devices from HAL:
CoolingDevice{mValue=100, mType=0, mName=test cooling device}

Temperature static thresholds from HAL:
TemperatureThreshold{mType=0, mName=TCPU, mHotThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, 99.0, 108.0], mColdThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, NaN, NaN]}
TemperatureThreshold{mType=1, mName=test sensor, mHotThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, 90.0, 100.0], mColdThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, NaN, NaN]}
TemperatureThreshold{mType=2, mName=TBATTERY, mHotThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, 65.0, 68.0], mColdThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, NaN, NaN]}

Tracked-On: OAM-110601

@sysopenci
Copy link

Improper Commit Message
Valid Commit Message
Improper Jira Status,
jira status not in ['In Progress','Implemented']

This change will convert Thermal HAL from HIDL to AIDL

Test:
adb shell dumpsys thermalservice.

Current temperatures from HAL:
        Temperature{mValue=65.0, mType=0, mName=TCPU, mStatus=0}
        Temperature{mValue=25.0, mType=1, mName=test sensor, mStatus=0}
        Temperature{mValue=25.0, mType=2, mName=TBATTERY, mStatus=0}

Current cooling devices from HAL:
        CoolingDevice{mValue=100, mType=0, mName=test cooling device}

Temperature static thresholds from HAL:
        TemperatureThreshold{mType=0, mName=TCPU, mHotThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, 99.0, 108.0], mColdThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, NaN, NaN]}
        TemperatureThreshold{mType=1, mName=test sensor, mHotThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, 90.0, 100.0], mColdThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, NaN, NaN]}
        TemperatureThreshold{mType=2, mName=TBATTERY, mHotThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, 65.0, 68.0], mColdThrottlingThresholds=[NaN, NaN, NaN, NaN, NaN, NaN, NaN]}

Tracked-On: OAM-112805
Signed-off-by: Vilas R K <vilas.r.k@intel.com>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@RajaniRanjan
Copy link
Contributor

LGTM

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckApprovals Some checks are failed. See the step results.html

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/5274

Copy link

@balajim001 balajim001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci removed the request for review from JeevakaPrabu November 7, 2023 06:42
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'preintegration' builder

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/5275

Done by "R K, Vilas" vilas.r.k@intel.com

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'premerge' builder

More details, logs, and binaries: /absp/builders/celadon-premerge/builds/3065

Done by "R K, Vilas" vilas.r.k@intel.com

@sysopenci sysopenci merged commit 51cd551 into projectceladon:master Nov 7, 2023
11 checks passed
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cactus finished building and testing your changes

It was requested for merge by "R K, Vilas" vilas.r.k@intel.com

so we merge it. Thanks for your contribution.

more details, logs, and binaries: /absp/builders/celadon-mergerequest/builds/3422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants