Skip to content

test/scripts: reuse development image tag - #7633

Open
AkashKumar7902 wants to merge 1 commit into
projectcontour:mainfrom
AkashKumar7902:agent/test-5277-reuse-dev-image
Open

test/scripts: reuse development image tag#7633
AkashKumar7902 wants to merge 1 commit into
projectcontour:mainfrom
AkashKumar7902:agent/test-5277-reuse-dev-image

Conversation

@AkashKumar7902

Copy link
Copy Markdown

Fixes #5277

What this PR does

  • reuses the ghcr.io/projectcontour/contour:dev image tag in both working-install scripts
  • explicitly restarts the standalone Contour Deployment and Envoy DaemonSet after loading a rebuilt image
  • restarts the Gateway provisioner and its managed Deployments and DaemonSets across namespaces

Why

The scripts currently generate a process-specific image tag for every run. That
forces Kubernetes to deploy the new build, but it also accumulates uniquely
tagged images in the local development environment.

Developer impact

Repeated working-tree deployments now reuse one development tag while still
restarting every long-running workload that embeds the rebuilt Contour binary.

Prior work

This is a fresh implementation of the approach discussed in #5854. Thanks to
@harshil1973 for the earlier implementation and to the maintainers who recorded
the expected restart behavior there.

Release note

Requested label: release-note/none-required. This changes local contributor
tooling only, so no changelog file is required for that category.

Testing

  • bash -n test/scripts/install-contour-working.sh test/scripts/install-provisioner-working.sh
  • git diff --check
  • make lint-codespell
  • disposable mock execution covering rendered images, cross-namespace Deployment/DaemonSet restarts, empty results, and kubectl get failure propagation
  • two consecutive real Kind v0.32.0 / Kubernetes v1.36.1 runs of each working-install script, verifying the stable :dev tag, changed image digests/IDs and pod UIDs, and final workload convergence

Use a stable dev tag for working installations and explicitly restart every
long-running workload that uses the rebuilt Contour image.

This preserves rapid local redeployment without accumulating a new image tag
on every run.

Fixes projectcontour#5277

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@AkashKumar7902
AkashKumar7902 marked this pull request as ready for review July 19, 2026 07:51
@AkashKumar7902
AkashKumar7902 requested a review from a team as a code owner July 19, 2026 07:51
@AkashKumar7902
AkashKumar7902 requested review from sunjayBhatia and tsaarni and removed request for a team July 19, 2026 07:51
@github-actions

Copy link
Copy Markdown

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve tagging & deployment for install-contour/provisioner-working

1 participant