docs(Client): remove missing options.maxShards option #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Thanks for the PR!
As for the availability of options.maxShards, the docs for this should have been removed in 75d58b7 (hence it is also unavailable in 0.1.x), but thanks to the missing [DEPRECATED] marker, I probably overlooked it and forgot to remove it.
TTtie
changed the title
TTtie
pushed a commit
that referenced
this pull request
Jul 9, 2023
TTtie
pushed a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the docs still show an
options.maxShardsoption but it appears to not work. The comment correctly notes thatThis option has been moved under 'options.gateway'I can only speculate but I suspect not marking it
[DEPRECATED]here may have been a simple oversight in the original MR, which does however mark it deprecated in index.d.ts.So I propose removing it to reduce potential confusion. I would also be up for making it work and adding a deprecation warning, but I see it looks like most of those have been ripped out from the
devbranch.