Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs reorganization #2450

Merged
merged 23 commits into from
Nov 8, 2024
Merged

Docs reorganization #2450

merged 23 commits into from
Nov 8, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Nov 2, 2024

Quick test based on a discussion in #2448. This reorganizes the docs by moving items from the top menu bar into the left-hand section navigation column.

I have gone for a rather radical approach and this is really proof of concept only at the moment. The top menu now only has overview, getting started, and API. All other stuff have been added to the getting started section. The getting_started.md file needs to have text in addition to the toctree to serve as a proper landing page.

I also think the migration guide might be better of in the top menu bar so its easy to find for existing users.

@EwoutH let me know your thoughts.

@quaquel quaquel added the docs Release notes label label Nov 2, 2024
@EwoutH
Copy link
Member

EwoutH commented Nov 2, 2024

Thanks for opening the PR. Looking at the rendered docs, I’m a bit conflicted.

I also think the migration guide might be better of in the top menu bar so its easy to find for existing users.

The challenge is that you can make this argument for a lot of the resources. Let me think about this a bit and maybe look at a few other libraries how they do it.

One idea is to (almost) abolish the top bar and have a semi permanent left side bar, since that fits more (but also takes more space).

@quaquel
Copy link
Member Author

quaquel commented Nov 2, 2024

One idea is to (almost) abolish the top bar and have a semi permanent left side bar, since that fits more (but also takes more space).

That might require changing to a completely different rtd style.

@EwoutH
Copy link
Member

EwoutH commented Nov 2, 2024

Rome isn’t built in a day (unfortunately).

I must say I find these docs very clean and clear in their layout, I wonder which brilliant maintainer designed those 😇

IMG_0074

@tpike3
Copy link
Member

tpike3 commented Nov 4, 2024

This is a good discussion thanks @quaquel

I like the pydata theme but am not necessarily opposed to other approaches.

Some thoughts would be

  • Agree to a simpler lay out with groupings
  • I would argue we can get rid of mesa packages, that really never went anywhere; maybe work with other groups like rbb4abm ??
  • Maybe instead of examples, we should call it gallery like Networkx and in this case we could merge How to and Examples in one page.

Just some off the top of the head thoughts. I am not tied to anything.

@quaquel
Copy link
Member Author

quaquel commented Nov 4, 2024

Thanks @tpike3 for the feedback. I have a few ideas that I'll try to implement later today that offer a bit of a middle ground between the current docs and this radical approach.

I would argue we can get rid of mesa packages, that really never went anywhere; maybe work with other groups like rbb4abm

Happy to remove it for now. I'll check with my colleagues who are involved in rbb4abm what might be possible.

@quaquel
Copy link
Member Author

quaquel commented Nov 4, 2024

I made a few changes. First, I moved examples and the migration guide out of the getting started page. They are now back in the top bar menu.

Screenshot 2024-11-04 at 16 03 41

Second, I figured out how to get stuff in the left hand column. This is populated based on a toctree directive, which can also be declared hidden. See here is what it now looks for the examples:

Screenshot 2024-11-04 at 16 03 52

Personally I think this is moving in the right direction. I want to add some text to the getting started page. Probably have a subsection called tutorials, with 2 tutorials for now. This creates space for more tutorials in the future. Again, feedback is welcome.

@quaquel
Copy link
Member Author

quaquel commented Nov 4, 2024

Mesa Overview might be combined with the getting started part. This would remove one more item from the top row that is only a single page and thus is not really a section with several associated pages. Some of the material might be used to fill out the getting started landing page, while the rest might be a good follow up in between tutorials and the full gory details of the API docs.

@EwoutH
Copy link
Member

EwoutH commented Nov 4, 2024

That's looking great!

Second, I figured out how to get stuff in the left hand column. This is populated based on a toctree directive, which can also be declared hidden.

That's good to know. Looking through it, I think the Section Navigation (left column) can be hidden in most cases (by default). Navigation could go through the top bar and the main Getting Started, Examples, etc. pages themselves.

@quaquel
Copy link
Member Author

quaquel commented Nov 6, 2024

I have done some further reorganization as discussed. So, I combined the old overview page and the new getting started idea. I reorganized the material a bit. So, the structure is now: tutorials, examples that ship with mesa, mesa packages overview, further resources.

I also updated the best practices a little bit wrt random.

This is ready for a proper review

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. Overal looks really good, clear improvement over what we had. Few minor comments.

docs/getting_started.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
docs/getting_started.md Show resolved Hide resolved
quaquel and others added 3 commits November 8, 2024 10:27
Co-authored-by: Ewout ter Hoeven <E.M.terHoeven@student.tudelft.nl>
adds init of cell_space to docs
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quaquel!

docs/index.md Outdated Show resolved Hide resolved
docs/getting_started.md Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@quaquel quaquel merged commit af5a146 into projectmesa:main Nov 8, 2024
12 checks passed
@quaquel quaquel deleted the docs_reorganization branch November 8, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants