Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include influxdb exporter role #408

Merged
merged 26 commits into from
Oct 23, 2024
Merged

feat: include influxdb exporter role #408

merged 26 commits into from
Oct 23, 2024

Conversation

dobbi84
Copy link
Contributor

@dobbi84 dobbi84 commented Aug 6, 2024

Include the Influxdb exporter role.

We rely on such exporter because we have applications that push metrics directly to Influxdb at runtime, using this exporter allows us to have those metrics in Prometheus. We have created this role getting inspired by the current Node Exporter role already present in this collection, thanks.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 6, 2024
SuperQ
SuperQ requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs the testing boilerplate under /tests/integration/targets/.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 25, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 25, 2024
@dobbi84 dobbi84 requested a review from SuperQ September 25, 2024 08:55
@SuperQ
Copy link
Contributor

SuperQ commented Sep 28, 2024

Can you please rebase this against main to pick up the changes in #395

dobbi84 and others added 26 commits October 23, 2024 17:53
@dobbi84 @gardar
feat: include influxdb exporter role
ad51f0b 
Include the [Influxdb exporter](https://github.com/prometheus/influxdb_exporter) role.

Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: include boiler plate for integration testing
dd0dbaa 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: include vars go_arch and go_arch_map needed for getting the ex…
745154f 
…porter from GH

Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: remove molecule directory check for dir not created
e22cd9f 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: fix alternative listen address in integration tests
10d70f0 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: align molecule tests to use get_target_hosts()
02aefec 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: refactor for _common role
6532e47 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/defaults/main.yml
b4fc645 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/molecule/alternative/molecule.yml
40fa0af 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/vars/main.yml
9cd3949 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: fix post review on refactor for _commons role
ccad1f4 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/molecule/alternative/molecule.yml
48ac76f 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/defaults/main.yml
941bc4d 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/meta/argument_specs.yml
39af896 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/meta/argument_specs.yml
dadbd12 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/meta/main.yml
a341529 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/tasks/preflight.yml
cc8cfda 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/tasks/preflight.yml
776211c 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/tasks/preflight.yml
894efb4 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
Update roles/influxdb_exporter/meta/argument_specs.yml
e13fd00 
Co-authored-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: Davide Obbi <126786027+dobbi84@users.noreply.github.com>
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: linter
031b5c3 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: linter
6533e31 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
fix: include config dir otherwise commons uses root
2d418a3 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: lint spec file
b82722c 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
chore: fix test default with correct home
552115a 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@dobbi84 @gardar
docs: update influxdb/README
73b4b70 
Signed-off-by: dobbi84 <davide.obbi@e4company.com>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 23, 2024
@gardar gardar merged commit 064141f into prometheus-community:main Oct 23, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar approved these changes

@SuperQ SuperQ Awaiting requested review from SuperQ

Assignees
No one assigned
Labels
enhancement New feature or request roles/influxdb_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dobbi84 @SuperQ @gardar